Skip to content

Add an option to use LTO for DPDK build

Andrzej Ostruszka dpdk-dev 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest10 patches 32 repliesIn review
  2. v110 patches 5 repliesSuperseded

Changes in v2 from the cover letter

-----------
- fixed building of shared libraries:
- gcc does not scan top level assembler statements so it missed that function implementations for specific versions were being used and was removing them
- fixed meson.build config files:
- moved from 'enable_lto' project option to built-in 'b_lto'
- documented that 'default_library' should be 'shared':
with 'default_library=static' (the default) the meson build with LTO is broken - this is because, SHARED_LIB is fixed in rte_config.h used by meson which leads to no alias for default version in generated static libraries (MAP_STATIC_SYMBOL() is empty)
- app/test: added log for failed bonding "config get"

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/10build: add an option to enable LTO build.travis.yml config/common_base config/meson.build +12 more+158 -5027 replies
2/10eventdev: fix possible use of uninitialized varlib/librte_eventdev/rte_event_timer_adapter.c+4 -41 reply
3/10app/eventdev: fix maybe-uninitialized warnings for LTO buildapp/test-eventdev/test_perf_common.c app/test-eventdev/test_pipeline_common.c+3 -31 reply
4/10event/octeontx2: fix maybe-uninitialized warnings for LTO builddrivers/event/octeontx2/otx2_tim_worker.h+1 -10 replies
5/10app/test: fix maybe-uninitialized warnings for LTO buildapp/test/test_hash_readwrite.c app/test/test_link_bonding_mode4.c app/test/test_memzone.c+11 -40 replies
6/10net/dpaa2: fix possible use of uninitialized varsdrivers/net/dpaa2/base/dpaa2_hw_dpni.c drivers/net/dpaa2/mc/dpkg.c drivers/net/dpaa2/mc/dpni.c+8 -40 replies
7/10net/e1000: fix maybe-uninitialized warnings for LTO builddrivers/net/e1000/base/e1000_82543.c drivers/net/e1000/base/e1000_ich8lan.c drivers/net/e1000/base/e1000_phy.c+3 -30 replies
8/10net/i40e: fix maybe-uninitialized warnings for LTO builddrivers/net/i40e/i40e_ethdev.c+1 -10 replies
9/10net/ifc: fix maybe-uninitialized warnings for LTO builddrivers/net/ifc/ifcvf_vdpa.c+9 -50 replies
10/10net/qede: fix maybe-uninitialized warnings for LTO builddrivers/net/qede/base/ecore_mcp.c+7 -60 replies

Reviews trailers per patch

3 of 10 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchBruce RichardsonJerin JacobNeil HormanYipeng Wang
SeriesA-b Series-acked-by A-b A-b R-b R-b R-b R-b A-b A-b A-b A-b A-b A-b
1/10A-b
2/10R-b
3/10R-b
4/10
5/10
6/10
7/10
8/10
9/10
10/10

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v2 thread

Cover letter [dpdk-dev] [PATCH v2 00/10] Add an option to use LTO for DPDK build

This patch series adds an option to make use of link time optimization (if compiler has support for it). It is split as follows:
- 1st patch (build) is the enablement
- remaining patches are fixes for the warnings produced by the compiler and they are split by directory/subsystem so their maintainers can easily find and verify the changes - please note that there are two groups:
* errors (or possible errors) - with title "fix possible use ..."
* false positives - warnings that _I_ think are not valid and the changes are made only to silence the compiler.

v2 Changes:
-----------
- fixed building of shared libraries:
- gcc does not scan top level assembler statements so it missed that function implementations for specific versions were being used and was removing them
- fixed meson.build config files:
- moved from 'enable_lto' project option to built-in 'b_lto'
- documented that 'default_library' should be 'shared':
with 'default_library=static' (the default) the meson build with LTO is broken - this is because, SHARED_LIB is fixed in rte_config.h used by meson which leads to no alias for default version in generated static libraries (MAP_STATIC_SYMBOL() is empty)
- app/test: added log for failed bonding "config get"

Andrzej Ostruszka (10):
build: add an option to enable LTO build
eventdev: fix possible use of uninitialized var app/eventdev: fix maybe-uninitialized warnings for LTO build event/octeontx2: fix maybe-uninitialized warnings for LTO build app/test: fix maybe-uninitialized warnings for LTO build net/dpaa2: fix possible use of uninitialized vars net/e1000: fix maybe-uninitialized warnings for LTO build net/i40e: fix maybe-uninitialized warnings for LTO build net/ifc: fix maybe-uninitialized warnings for LTO build net/qede: fix maybe-uninitialized warnings for LTO build

 .travis.yml                                   |  7 ++++
 app/test-eventdev/test_perf_common.c          |  2 +-
 app/test-eventdev/test_pipeline_common.c      |  4 +-
 app/test/test_hash_readwrite.c                |  2 +-
 app/test/test_link_bonding_mode4.c            | 10 ++++-
 app/test/test_memzone.c                       |  3 +-
 config/common_base                            |  5 +++
 config/meson.build                            | 15 ++++++++
 doc/guides/prog_guide/lto.rst                 | 37 +++++++++++++++++++
 doc/guides/rel_notes/release_19_11.rst        |  8 ++++
 drivers/event/octeontx2/otx2_tim_worker.h     |  2 +-
 drivers/net/dpaa2/base/dpaa2_hw_dpni.c        |  1 +
 drivers/net/dpaa2/mc/dpkg.c                   |  2 +-
 drivers/net/dpaa2/mc/dpni.c                   |  9 +++--
 drivers/net/e1000/base/e1000_82543.c          |  2 +-
 drivers/net/e1000/base/e1000_ich8lan.c        |  2 +-
 drivers/net/e1000/base/e1000_phy.c            |  2 +-
 drivers/net/i40e/i40e_ethdev.c                |  2 +-
 drivers/net/ifc/ifcvf_vdpa.c                  | 14 ++++---
 drivers/net/qede/base/ecore_mcp.c             | 13 ++++---
 lib/librte_distributor/rte_distributor.c      | 18 ++++-----
 lib/librte_distributor/rte_distributor_v20.c  | 18 ++++-----
 lib/librte_eventdev/rte_event_timer_adapter.c |  8 ++--
 lib/librte_lpm/rte_lpm.c                      | 28 +++++++-------
 lib/librte_lpm/rte_lpm6.c                     | 16 ++++----
 lib/librte_timer/rte_timer.c                  | 20 +++++-----
 mk/toolchain/clang/rte.toolchain-compat.mk    |  4 ++
 mk/toolchain/clang/rte.vars.mk                |  8 ++++
 mk/toolchain/gcc/rte.toolchain-compat.mk      |  4 ++
 mk/toolchain/gcc/rte.vars.mk                  | 12 ++++++
 mk/toolchain/icc/rte.vars.mk                  |  8 ++++
 31 files changed, 205 insertions(+), 81 deletions(-)
 create mode 100644 doc/guides/prog_guide/lto.rst
Signature · 1 line
2.17.1