Skip to content

virtiofs: Fix various races and cleanups round 1

Vivek Goyal linux-fsdevel lkml virtio-fs virtualization 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest18 patches 74 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/18virtiofs: Remove request from processing list before calling endfs/fuse/virtio_fs.c+4 -02 replies
2/18virtiofs: Check whether hiprio queue is connected at submission timefs/fuse/virtio_fs.c+8 -12 replies
2/18virtiofs: Check whether hiprio queue is connected at submission timefs/fuse/virtio_fs.c+8 -10 replies
3/18virtiofs: Pass fsvq instead of vq as parameter to virtio_fs_enqueue_reqfs/fuse/virtio_fs.c+5 -42 replies
4/18virtiofs: Check connected state for VQ_REQUEST queue as wellfs/fuse/virtio_fs.c+6 -02 replies
4/18virtiofs: Check connected state for VQ_REQUEST queue as wellfs/fuse/virtio_fs.c+6 -00 replies
5/18Maintain count of in flight requests for VQ_REQUEST queuefs/fuse/virtio_fs.c+4 -02 replies
5/18Maintain count of in flight requests for VQ_REQUEST queuefs/fuse/virtio_fs.c+4 -00 replies
6/18virtiofs: ->remove should not clean virtiofs fuse devicesfs/fuse/virtio_fs.c+0 -22 replies
6/18virtiofs: ->remove should not clean virtiofs fuse devicesfs/fuse/virtio_fs.c+0 -20 replies
7/18virtiofs: Stop virtiofs queues when device is being removedfs/fuse/virtio_fs.c+14 -02 replies
7/18virtiofs: Stop virtiofs queues when device is being removedfs/fuse/virtio_fs.c+14 -00 replies
8/18virtiofs: Drain all pending requests during ->remove timefs/fuse/virtio_fs.c+51 -329 replies
9/18virtiofs: Add an helper to start all the queuesfs/fuse/virtio_fs.c+16 -32 replies
9/18virtiofs: Add an helper to start all the queuesfs/fuse/virtio_fs.c+16 -30 replies
10/18virtiofs: Do not use device managed mem for virtio_fs and virtio_fs_vqfs/fuse/virtio_fs.c+8 -52 replies
10/18virtiofs: Do not use device managed mem for virtio_fs and virtio_fs_vqfs/fuse/virtio_fs.c+8 -50 replies
11/18virtiofs: stop and drain queues after sending DESTROYfs/fuse/virtio_fs.c+8 -31 reply
11/18virtiofs: stop and drain queues after sending DESTROYfs/fuse/virtio_fs.c+8 -30 replies
12/18virtiofs: Use virtio_fs_free_devs() in error pathfs/fuse/virtio_fs.c+1 -22 replies
12/18virtiofs: Use virtio_fs_free_devs() in error pathfs/fuse/virtio_fs.c+1 -20 replies
13/18virtiofs: Do not access virtqueue in request submission pathfs/fuse/virtio_fs.c+4 -42 replies
13/18virtiofs: Do not access virtqueue in request submission pathfs/fuse/virtio_fs.c+4 -40 replies
14/18virtiofs: Add a fuse_iqueue operation to put() referencefs/fuse/fuse_i.h fs/fuse/inode.c+11 -04 replies
14/18virtiofs: Add a fuse_iqueue operation to put() referencefs/fuse/fuse_i.h fs/fuse/inode.c+11 -00 replies
15/18virtiofs: Make virtio_fs object refcountedfs/fuse/virtio_fs.c+43 -98 replies
15/18virtiofs: Make virtio_fs object refcountedfs/fuse/virtio_fs.c+43 -90 replies
16/18virtiofs: Use virtio_fs_mutex for races w.r.t ->remove and mount pathfs/fuse/virtio_fs.c+22 -107 replies
16/18virtiofs: Use virtio_fs_mutex for races w.r.t ->remove and mount pathfs/fuse/virtio_fs.c+22 -100 replies
17/18virtiofs: Remove TODO to quiesce/end_requestsfs/fuse/virtio_fs.c+0 -22 replies
17/18virtiofs: Remove TODO to quiesce/end_requestsfs/fuse/virtio_fs.c+0 -20 replies
18/18virtiofs: Remove TODO item from virtio_fs_free_devs()fs/fuse/virtio_fs.c+0 -22 replies
18/18virtiofs: Remove TODO item from virtio_fs_free_devs()fs/fuse/virtio_fs.c+0 -20 replies

Reviews trailers per patch

30 of 33 patches have a Reviewed-by or Acked-by.

PatchStefan Hajnoczi
1/18R-b R-b
2/18R-b R-b
2/18R-b R-b
3/18R-b R-b
4/18R-b R-b
4/18R-b R-b
5/18R-b R-b
5/18R-b R-b
6/18R-b R-b
6/18R-b R-b
7/18R-b R-b
7/18R-b R-b
8/18
9/18R-b R-b
9/18R-b R-b
10/18R-b R-b
10/18R-b R-b
11/18R-b
11/18R-b
12/18R-b R-b
12/18R-b R-b
13/18R-b R-b
13/18R-b R-b
14/18
14/18
15/18R-b
15/18R-b
16/18R-b R-b R-b R-b
16/18R-b R-b R-b R-b
17/18R-b R-b
17/18R-b R-b
18/18R-b R-b
18/18R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 00/18] virtiofs: Fix various races and cleanups round 1

Hi,

Michael Tsirkin pointed out issues w.r.t various locking related TODO items and races w.r.t device removal.

In this first round of cleanups, I have taken care of most pressing issues.

These patches apply on top of following.

git://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/fuse.git#virtiofs-v4

I have tested these patches with mount/umount and device removal using qemu monitor. For example.

virsh qemu-monitor-command --hmp vm9-f28 device_del myvirtiofs

Now a mounted device can be removed and file system will return errors -ENOTCONN and one can unmount it.

Miklos, if you are fine with the patches, I am fine if you fold these all into existing patch. I kept them separate so that review is easier.

Any feedback or comments are welcome.

Thanks
Vivek

Vivek Goyal (18):
virtiofs: Remove request from processing list before calling end
virtiofs: Check whether hiprio queue is connected at submission time
virtiofs: Pass fsvq instead of vq as parameter to
virtio_fs_enqueue_req
virtiofs: Check connected state for VQ_REQUEST queue as well Maintain count of in flight requests for VQ_REQUEST queue
virtiofs: ->remove should not clean virtiofs fuse devices
virtiofs: Stop virtiofs queues when device is being removed
virtiofs: Drain all pending requests during ->remove time
virtiofs: Add an helper to start all the queues
virtiofs: Do not use device managed mem for virtio_fs and virtio_fs_vq
virtiofs: stop and drain queues after sending DESTROY
virtiofs: Use virtio_fs_free_devs() in error path
virtiofs: Do not access virtqueue in request submission path
virtiofs: Add a fuse_iqueue operation to put() reference
virtiofs: Make virtio_fs object refcounted
virtiofs: Use virtio_fs_mutex for races w.r.t ->remove and mount path
virtiofs: Remove TODO to quiesce/end_requests
virtiofs: Remove TODO item from virtio_fs_free_devs()

 fs/fuse/fuse_i.h    |   5 +
 fs/fuse/inode.c     |   6 +
 fs/fuse/virtio_fs.c | 259 ++++++++++++++++++++++++++++++++------------
 3 files changed, 198 insertions(+), 72 deletions(-)
Signature · 1 line
2.20.1