a few commit-graph improvements
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest2 patches 5 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | commit-graph: don't show progress percentages while expanding reachable commitscommit-graph.c | +1 | 3 replies | |
| 2/2 | commit-graph: turn off save_commit_bufferbuiltin/ | +2 | 2 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 0/2] a few commit-graph improvements
We've been playing with commit graphs at GitHub and found a few bits of low-hanging fruit (one liners -- it doesn't get any lower than that).
The first one is actually a resurrection of a patch from March:
https://public-inbox.org/git/[email protected]/
where the progress bar sometimes prints nonsense. There's some discussion in that thread about how we could sometimes show a real percentage instead of a counting-up progress meter. But given the number of corner cases discussed, and the fact that nothing has happened for 6 months, I think we should first make sure we're always doing the _correct_ thing, and then people can build a nicer meter on top if they want to.
The second is a fix for a small memory "leak", but it makes a big difference.
[1/2]: commit-graph: don't show progress percentages while expanding reachable commits [2/2]: commit-graph: turn off save_commit_buffer
builtin/commit-graph.c | 2 ++ commit-graph.c | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-)
-Peff