Skip to content

opencapi: enable card reset and link retraining

Frederic Barrat linuxppc-dev 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest11 patches 7 repliesIn review
  2. v111 patches 38 repliesSuperseded

Changes in v2 from the cover letter

- rebase on latest kernel
- clarify the ref counting done for NPU devices when the PE is setup
- address comments from Andrew and Alastair

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/11powerpc/powernv/ioda: Fix ref count for devices with their own PEarch/powerpc/platforms/powernv/pci-ioda.c+12 -74 replies
2/11powerpc/powernv/ioda: Protect PE listarch/powerpc/platforms/powernv/pci-ioda.c+5 -10 replies
3/11powerpc/powernv/ioda: set up PE on opencapi device when enablingarch/powerpc/platforms/powernv/pci-ioda.c+23 -80 replies
4/11powerpc/powernv/ioda: Release opencapi devicearch/powerpc/platforms/powernv/pci-ioda.c+40 -191 reply
5/11powerpc/powernv/ioda: Find opencapi slot for a device nodearch/powerpc/include/asm/pnv-pci.h arch/powerpc/platforms/powernv/pci.c+15 -101 reply
6/11pci/hotplug/pnv-php: Remove erroneous warningdrivers/pci/hotplug/pnv_php.c+0 -60 replies
7/11pci/hotplug/pnv-php: Improve error msg on power state change failuredrivers/pci/hotplug/pnv_php.c+11 -50 replies
8/11pci/hotplug/pnv-php: Register opencapi slotsdrivers/pci/hotplug/pnv_php.c+5 -01 reply
9/11pci/hotplug/pnv-php: Relax check when disabling slotdrivers/pci/hotplug/pnv_php.c+7 -10 replies
10/11pci/hotplug/pnv-php: Wrap warnings in macrodrivers/pci/hotplug/pnv_php.c+28 -230 replies
11/11ocxl: Add PCI hotplug dependency to Kconfigdrivers/misc/ocxl/Kconfig+1 -00 replies

Reviews trailers per patch

All 11 patches have a Reviewed-by or Acked-by.

PatchAndrew DonnellanAlastair D'Silva
1/11R-b
2/11R-b
3/11R-b R-b
4/11R-b
5/11R-b
6/11R-b R-b
7/11R-b R-b
8/11R-b
9/11R-b R-b
10/11R-b R-b
11/11R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 00/11] opencapi: enable card reset and link retraining

This is the linux part of the work to use the PCI hotplug framework to control an opencapi card so that it can be reset and re-read after flashing a new FPGA image. The changes required in skiboot are now upstream. On an old skiboot, this series will do nothing.

A virtual PCI slot is created for the opencapi adapter and its state can be controlled through the pnv-php hotplug driver:

echo 0|1 > /sys/bus/pci/slots/OPENCAPI-<...>/power

Note that the power to the card is not really turned off, as the card needs to stay on to be flashed with a new image. Instead the card is in reset.

The first part of the series mostly deals with the pci/ioda state, as the opencapi devices can now go away and the state needs to be cleaned up.

The second part is modifications to the PCI hotplug driver on powernv, so that a virtual slot is created for the opencapi adapters found in the device tree.

Changelog:
v2:
- rebase on latest kernel
- clarify the ref counting done for NPU devices when the PE is setup
- address comments from Andrew and Alastair

Frederic Barrat (11):
powerpc/powernv/ioda: Fix ref count for devices with their own PE powerpc/powernv/ioda: Protect PE list powerpc/powernv/ioda: set up PE on opencapi device when enabling powerpc/powernv/ioda: Release opencapi device powerpc/powernv/ioda: Find opencapi slot for a device node pci/hotplug/pnv-php: Remove erroneous warning pci/hotplug/pnv-php: Improve error msg on power state change failure pci/hotplug/pnv-php: Register opencapi slots pci/hotplug/pnv-php: Relax check when disabling slot pci/hotplug/pnv-php: Wrap warnings in macro
ocxl: Add PCI hotplug dependency to Kconfig

 arch/powerpc/include/asm/pnv-pci.h        |   1 +
 arch/powerpc/platforms/powernv/pci-ioda.c | 115 +++++++++++++++-------
 arch/powerpc/platforms/powernv/pci.c      |  24 +++--
 drivers/misc/ocxl/Kconfig                 |   1 +
 drivers/pci/hotplug/pnv_php.c             |  82 ++++++++-------
 5 files changed, 145 insertions(+), 78 deletions(-)
Signature · 1 line
2.21.0