Skip to content

ocaml abi fixes

Ian Jackson xen-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest12 patches 12 repliesIn review
  2. v13 patches 2 repliesSuperseded

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/12tools/ocaml: Add missing X86_EMU_VPCItools/ocaml/libs/xc/xenctrl.ml tools/ocaml/libs/xc/xenctrl.mli+2 -00 replies
2/12tools/ocaml: Add missing CAP_PVtools/ocaml/libs/xc/xenctrl.ml tools/ocaml/libs/xc/xenctrl.mli+5 -10 replies
3/12tools/ocaml: Introduce xenctrl ABI build-time checks.gitignore tools/ocaml/libs/xc/Makefile tools/ocaml/libs/xc/abi-check +2 more+143 -202 replies
4/12xen/domctl: Drop guest suffix from XEN_DOMCTL_CDF_hvmtools/libxl/libxl_create.c tools/python/xen/lowlevel/xc/xc.c xen/arch/arm/domain.c +7 more+14 -144 replies
5/12tools/ocaml: abi-check: Add commentstools/ocaml/libs/xc/abi-check+15 -00 replies
6/12tools/ocaml: abi handling: Provide ocaml->C conversion/checktools/ocaml/libs/xc/abi-check tools/ocaml/libs/xc/xenctrl_stubs.c+17 -12 replies
7/12tools/ocaml: abi-check: Improve output and error messagestools/ocaml/libs/xc/abi-check+8 -60 replies
8/12tools/ocaml: abi-check: Cope with multiple conversions of same typetools/ocaml/libs/xc/abi-check+5 -00 replies
9/12tools/ocaml: Reformat domain_create_flagtools/ocaml/libs/xc/xenctrl.ml tools/ocaml/libs/xc/xenctrl.mli+6 -20 replies
10/12tools/ocaml: abi-check: Check properly.tools/ocaml/libs/xc/abi-check+8 -10 replies
11/12tools/ocaml: tools/ocaml: Add missing CDF_* valuestools/ocaml/libs/xc/xenctrl.ml tools/ocaml/libs/xc/xenctrl.mli+6 -00 replies
12/12tools/ocaml: abi: Use formal conversion and check in more placestools/ocaml/libs/xc/xenctrl_stubs.c xen/include/public/domctl.h+13 -61 reply

Reviews trailers per patch

3 of 12 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchChristian LindigJan BeulichJulien Grall
SeriesA-b
1/12
2/12
3/12A-b A-b
4/12A-b A-b
5/12
6/12
7/12
8/12
9/12
10/12
11/12
12/12A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v3 thread

Cover letter [Xen-devel] [PATCH v3 00/12] ocaml abi fixes

This now has further updates and improvements. Patches 1-3 are as before. Patches 4-12 are new. Thanks to Andy for his work (in particular, some debugging and commentary for my script) which I have incorporated here.

This is available as a git branch here
https://xenbits.xen.org/gitweb/?p=people/iwj/xen.git;a=summary
-b wip.ocaml.v3

Andrew Cooper (5):
tools/ocaml: Add missing CAP_PV
xen/domctl: Drop guest suffix from XEN_DOMCTL_CDF_hvm tools/ocaml: abi handling: Provide ocaml->C conversion/check tools/ocaml: Reformat domain_create_flag
tools/ocaml: abi: Use formal conversion and check in more places

Ian Jackson (7):
tools/ocaml: Add missing X86_EMU_VPCI
tools/ocaml: Introduce xenctrl ABI build-time checks tools/ocaml: abi-check: Add comments
tools/ocaml: abi-check: Improve output and error messages tools/ocaml: abi-check: Cope with multiple conversions of same type tools/ocaml: abi-check: Check properly.
tools/ocaml: tools/ocaml: Add missing CDF_* values

 .gitignore                          |   1 +
 tools/libxl/libxl_create.c          |   2 +-
 tools/ocaml/libs/xc/Makefile        |   5 ++
 tools/ocaml/libs/xc/abi-check       | 114 ++++++++++++++++++++++++++++++++++++
 tools/ocaml/libs/xc/xenctrl.ml      |   9 ++-
 tools/ocaml/libs/xc/xenctrl.mli     |  13 +++-
 tools/ocaml/libs/xc/xenctrl_stubs.c |  95 ++++++++++++++++++++++--------
 tools/python/xen/lowlevel/xc/xc.c   |   2 +-
 xen/arch/arm/domain.c               |   2 +-
 xen/arch/arm/domain_build.c         |   2 +-
 xen/arch/arm/setup.c                |   2 +-
 xen/arch/x86/domain.c               |   4 +-
 xen/arch/x86/setup.c                |   2 +-
 xen/common/domain.c                 |   4 +-
 xen/include/public/domctl.h         |   8 ++-
 xen/include/public/sysctl.h         |   4 ++
 xen/include/xen/sched.h             |   4 +-
 17 files changed, 232 insertions(+), 41 deletions(-)
 create mode 100755 tools/ocaml/libs/xc/abi-check
Signature · 7 lines
2.11.0


_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel