Skip to content

mptcp sparse "fixes"

Florian Westphal mptcp 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4protocol: avoid sparse endian warningnet/mptcp/protocol.h+1 -10 replies
2/4options: fix __sum16 degrades to integer sparse warningnet/mptcp/options.c+2 -20 replies
3/4crypto: include protocol.h to get function prototypesnet/mptcp/crypto.c+2 -00 replies
4/4pm: avoid endianness conversion warningnet/mptcp/pm.c+1 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [MPTCP] [PATCH 0/4] mptcp sparse "fixes"

NB: these patches don't fix anything because nothing is broken.

The "sparse" checker complains about various constructs, this fixes some of those. All of these can be squashed, I've placed the name of the target commit in the change logs.

There are more sparse warnings in the code base, I am intentionally skipping those for now as its in code that is still "in flux".

For example the icsk ulp data pointer now has an __rcu annotation upstream so sparse complains because we don't use rcu_dereference() or similar.

In any case, I think those can be fixed once the code has stabilized more. I am sending these now because they are in more "mature" areas and it reduces the delta between my working tree and the "export" branch.

Thanks,
Florian

 crypto.c   |    2 ++
 options.c  |    4 ++--
 pm.c       |    2 +-
 protocol.h |    2 +-
 4 files changed, 6 insertions(+), 4 deletions(-)