Skip to content

Hardware operations for the SJA1105 DSA PTP clock

Vladimir Oltean netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v2 Latest7 patches 4 repliesIn review

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7net: dsa: sja1105: Get rid of global declaration of struct ptp_clock_infodrivers/net/dsa/sja1105/sja1105_ptp.c+14 -150 replies
2/7net: dsa: sja1105: Change the PTP command access patterndrivers/net/dsa/sja1105/sja1105.h drivers/net/dsa/sja1105/sja1105_ptp.c+6 -50 replies
3/7net: dsa: sja1105: Switch to hardware operations for PTPdrivers/net/dsa/sja1105/sja1105.h drivers/net/dsa/sja1105/sja1105_main.c drivers/net/dsa/sja1105/sja1105_ptp.c +2 more+122 -1174 replies
4/7net: dsa: sja1105: Implement the .gettimex64 system call for PTPdrivers/net/dsa/sja1105/sja1105.h drivers/net/dsa/sja1105/sja1105_main.c drivers/net/dsa/sja1105/sja1105_ptp.c +2 more+48 -250 replies
5/7net: dsa: sja1105: Restore PTP time after switch resetdrivers/net/dsa/sja1105/sja1105_main.c drivers/net/dsa/sja1105/sja1105_ptp.c drivers/net/dsa/sja1105/sja1105_ptp.h +1 more+101 -260 replies
6/7net: dsa: sja1105: Disallow management xmit during switch resetdrivers/net/dsa/sja1105/sja1105_main.c+4 -00 replies
7/7net: dsa: sja1105: Move PTP data to its own private structuredrivers/net/dsa/sja1105/sja1105.h drivers/net/dsa/sja1105/sja1105_main.c drivers/net/dsa/sja1105/sja1105_ptp.c +1 more+84 -580 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 net-next 0/7] Hardware operations for the SJA1105 DSA PTP clock

This series performs the following changes to the PTP portion of the driver:
- Deletes the timecounter/cyclecounter implementation of a free-running PHC and replaces it with actual hardware corrections of the PTP timestamping clock.
- Deletes the approximation of timecounter_init() with the argument of ktime_to_ns(ktime_get_real()) (aka system clock) that is currently done in sja1105_ptp_reset. Now that the PTP clock can keep the wall time in hardware, it makes sense to do so (and thus arises the need to restore the PTP time after resetting the switch).
- Profits from the fact that timecounter/cyclecounter code has been removed from sja1105_main.c, and goes a step further by doing some more cleanup and making the PTP Kconfig more self-contained. The cleanup also covers preparing the driver for the gettimex API (PTP_SYS_OFFSET_EXTENDED ioctl) - an API which at the moment does not have the best implementation available in the kernel for this switch, but for which the addition of a better API is trivial after the cleanup.

 drivers/net/dsa/sja1105/sja1105.h      |  18 +-
 drivers/net/dsa/sja1105/sja1105_main.c |  66 ++++--
 drivers/net/dsa/sja1105/sja1105_ptp.c  | 283 +++++++++++++------------
 drivers/net/dsa/sja1105/sja1105_ptp.h  |  78 +++++++
 drivers/net/dsa/sja1105/sja1105_spi.c  |  42 ++--
 5 files changed, 310 insertions(+), 177 deletions(-)
Signature · 17 lines
These are the PTP patches that have been split apart from:
https://www.spinics.net/lists/netdev/msg597214.html
("tc-taprio offload for SJA1105 DSA").
As such I have marked them as v2. There are no changes since the
tc-taprio patchset, it is only for better review-ability.

Vladimir Oltean (7):
  net: dsa: sja1105: Get rid of global declaration of struct
    ptp_clock_info
  net: dsa: sja1105: Change the PTP command access pattern
  net: dsa: sja1105: Switch to hardware operations for PTP
  net: dsa: sja1105: Implement the .gettimex64 system call for PTP
  net: dsa: sja1105: Restore PTP time after switch reset
  net: dsa: sja1105: Disallow management xmit during switch reset
  net: dsa: sja1105: Move PTP data to its own private structure

2.17.1