Skip to content

proper locking on bitmap add/remove paths

Vladimir Sementsov-Ogievskiy qemu-devel 3 versions – Applied

Status from this message: Thanks, applied to my bitmaps tree:

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest3 patches 5 repliesApplied
  2. v23 patches 4 repliesSuperseded
  3. v13 patches 3 repliesSuperseded

Changes in v3 from the cover letter

01: add John's r-b
02: - fix bdrv_remove_persistent_dirty_bitmap return value
- drop extra zeroing of ret in qcow2_remove_persistent_dirty_bitmap
03: add John's r-b

Patches in v3 Applied

#Subject and filesSizeRepliesApplied
1/3block: move bdrv_can_store_new_dirty_bitmap to block/dirty-bitmap.cblock.c block/dirty-bitmap.c+22 -220 replies
2/3block/dirty-bitmap: return int from bdrv_remove_persistent_dirty_bitmapblock/dirty-bitmap.c block/qcow2-bitmap.c block/qcow2.h +3 more+25 -251 reply
3/3block/qcow2: proper locking on bitmap add/remove pathsblock/dirty-bitmap.c block/qcow2-bitmap.c block/qcow2.c +3 more+131 -480 replies

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchJohn Snow
1/3R-b
2/3R-b
3/3R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/3] proper locking on bitmap add/remove paths

Hi all!

We need to lock qcow2 mutex on accessing in-image metadata, especially on updating this metadata. Let's implement it.

v3:
01: add John's r-b
02: - fix bdrv_remove_persistent_dirty_bitmap return value
- drop extra zeroing of ret in qcow2_remove_persistent_dirty_bitmap
03: add John's r-b

Vladimir Sementsov-Ogievskiy (3):
block: move bdrv_can_store_new_dirty_bitmap to block/dirty-bitmap.c block/dirty-bitmap: return int from
bdrv_remove_persistent_dirty_bitmap
block/qcow2: proper locking on bitmap add/remove paths

 block/qcow2.h                |  14 ++---
 include/block/block_int.h    |  14 ++---
 include/block/dirty-bitmap.h |   5 +-
 block.c                      |  22 -------
 block/dirty-bitmap.c         | 119 +++++++++++++++++++++++++++++++++--
 block/qcow2-bitmap.c         |  36 +++++++----
 block/qcow2.c                |   5 +-
 blockdev.c                   |  28 +++------
 8 files changed, 163 insertions(+), 80 deletions(-)
Signature · 1 line
2.21.0