Skip to content

mbuf: add bulk free function

Morten Brørup dpdk-dev 11 versions – Applied

Status from this message: Applied, thanks

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v9 Latest2 patches 1 replyApplied
  2. v82 patches 2 repliesSuperseded
  3. v71 patch 0 repliesSuperseded
Earlier versions · 8
VersionPostedPatchesRepliesStatus
v6 posting 3/32 patches3 repliesSuperseded
v6 posting 2/32 patches1 replySuperseded
v6 posting 1/32 patches1 replySuperseded
v51 patch3 repliesSuperseded
v41 patch4 repliesSuperseded
v33 patches0 repliesSuperseded
v22 patches11 repliesSuperseded
v11 patch8 repliesSuperseded

Changes in v9 from the cover letter

* Fix a typo in a description.
* In the unit test, make chain length a #define and add a few RTE_BUILD_BUG_ON().
* The unit test prints when allocating the mbuf pools for the bulk tests. Also print when freeing them.

Patches in v9 Applied

#Subject and filesSizeRepliesApplied
1/2mbuf: add bulk free functionlib/librte_mbuf/rte_mbuf.c lib/librte_mbuf/rte_mbuf.h lib/librte_mbuf/rte_mbuf_version.map+82 -00 replies
2/2mbuf: add unit test for bulk alloc/free functionsapp/test/test_mbuf.c+179 -00 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchKonstantin AnanyevAndrew RybchenkoStephen HemmingerOlivier Matz
SeriesA-b R-b A-b A-b
1/2A-b R-b A-b A-b
2/2A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v9 thread

Cover letter [dpdk-dev] [PATCH v9 0/2] mbuf: add bulk free function

Add function for freeing a bulk of mbufs.

Add unit test for functions for allocating and freeing a bulk of mbufs.

---

v9:
* Fix a typo in a description.
* In the unit test, make chain length a #define and add a few RTE_BUILD_BUG_ON().
* The unit test prints when allocating the mbuf pools for the bulk tests. Also print when freeing them.
v8:
* Add unit test, covering both bulk alloc and bulk free.
v7:
* Squash multiple modifications into one.
v6:
* Remove __rte_always_inline from static function.
The compiler will inline anyway.
v5:
* Rename variables from "free" to "pending" for improved readability.
* Add prefix __ to rte_pktmbuf_free_seg_via_array().
* Add array size parameter to __rte_pktmbuf_free_seg_via_array(). The compiler will optimize the parameter away anyway.
* Add description to __rte_pktmbuf_free_seg_via_array().
* Minor description updates.
v4:
* Mark as experimental by adding __rte_experimental.
* Add function to experimental section of map file.
* Fix source code formatting regarding pointer to pointer.
* Squash multiple modifications into one.
v3:
* Bugfix: Handle pakets with multiple segments.
* Add inline helper function, mainly for readability.
* Fix source code formatting regarding indentation.
v2:
* Function is not inline.
* Optimize to free multible mbufs belonging to the same mempool in bulk. Inspired by ixgbe_tx_free_bufs(), but allowing NULL pointers in the array, just like rte_pktmbuf_free() can take a NULL pointer.
* Use unsigned int instead of unsigned. Passes checkpatch, but mismatches the original coding style of the modified files.
* Fix a typo in the description headline: mempools is plural.

Morten Brørup (2):
mbuf: add bulk free function
mbuf: add unit test for bulk alloc/free functions

 app/test/test_mbuf.c                 | 179 +++++++++++++++++++++++++++
 lib/librte_mbuf/rte_mbuf.c           |  66 ++++++++++
 lib/librte_mbuf/rte_mbuf.h           |  15 +++
 lib/librte_mbuf/rte_mbuf_version.map |   1 +
 4 files changed, 261 insertions(+)
Signature · 1 line
2.17.1