Skip to content

Automatic RCU read unlock

Dr. David Alan Gilbert (git) qemu-devel 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest5 patches 1 replyIn review
  2. v35 patches 13 repliesSuperseded
  3. v25 patches 11 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v13 patches16 repliesSuperseded

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5rcu: Add automatically released rcu_read_lock variantsdocs/devel/rcu.txt include/qemu/rcu.h+41 -00 replies
2/5migration: Fix missing rcu_read_unlockmigration/ram.c+13 -140 replies
3/5migration: Use automatic rcu_read unlock in ram.cmigration/ram.c+121 -1380 replies
4/5migration: Use automatic rcu_read unlock in rdma.cmigration/rdma.c+11 -460 replies
5/5rcu: Use automatic rc_read unlock in core memory/exec codeexec.c include/exec/ram_addr.h memory.c+118 -1510 replies

Reviews trailers per patch

All 5 patches have a Reviewed-by or Acked-by.

PatchDaniel P. BerrangéPaolo Bonzini
1/5R-b A-b
2/5R-b
3/5R-b
4/5R-b
5/5R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH v4 0/5] Automatic RCU read unlock

From: "Dr. David Alan Gilbert" <[email protected]>

This patch uses glib's g_auto mechanism to automatically free rcu_read_lock's at the end of the block. Given that humans have a habit of forgetting an error path somewhere it's best to leave it to the compiler.

v4
Mark the '_rcu_read_auto_' variable as 'unused' to work around a clang bug.

Dr. David Alan Gilbert (5):
rcu: Add automatically released rcu_read_lock variants
migration: Fix missing rcu_read_unlock
migration: Use automatic rcu_read unlock in ram.c
migration: Use automatic rcu_read unlock in rdma.c
rcu: Use automatic rc_read unlock in core memory/exec code

 docs/devel/rcu.txt      |  16 +++
 exec.c                  | 116 +++++++---------
 include/exec/ram_addr.h | 138 +++++++++----------
 include/qemu/rcu.h      |  25 ++++
 memory.c                |  15 +--
 migration/ram.c         | 286 +++++++++++++++++++---------------------
 migration/rdma.c        |  57 ++------
 7 files changed, 304 insertions(+), 349 deletions(-)
Signature · 1 line
2.23.0