Skip to content

crypto/luks: preparation for encryption key managment

Maxim Levitsky qemu-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest13 patches 2 repliesIn review
  2. v112 patches 5 repliesSuperseded

Changes in v2 from the cover letter

I addressed all the review comments
I also added another minor patch to improve an error messsage when trying to create too large file, for which I have an open bug that waits to be closed.
Its also is form of refactoring, and thus I guess it makes sense to include it here.

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/13block-crypto: misc refactoringblock/crypto.c+6 -62 replies
2/13qcrypto-luks: rename some fields in QCryptoBlockLUKSHeadercrypto/block-luks.c+47 -440 replies
3/13qcrypto-luks: don't overwrite cipher_mode in headercrypto/block-luks.c+6 -30 replies
4/13qcrypto-luks: simplify masterkey and masterkey lengthcrypto/block-luks.c+21 -230 replies
5/13qcrypto-luks: pass keyslot index rather that pointer to the keyslotcrypto/block-luks.c+3 -30 replies
6/13qcrypto-luks: use the parsed encryption settings in QCryptoBlockLUKScrypto/block-luks.c+79 -900 replies
7/13qcrypto-luks: purge unused error codes from open callbackcrypto/block-luks.c+13 -320 replies
8/13qcrypto-luks: extract store and load headercrypto/block-luks.c+93 -620 replies
9/13qcrypto-luks: extract check and parse headercrypto/block-luks.c+125 -980 replies
10/13qcrypto-luks: extract store key functioncrypto/block-luks.c+181 -1230 replies
11/13qcrypto-luks: simplify the math used for keyslot locationscrypto/block-luks.c+40 -230 replies
12/13qcrypto-luks: more rigorous header checkingcrypto/block-luks.c+52 -00 replies
13/13LUKS: better error message when creating too large filesblock/crypto.c+19 -20 replies

Reviews trailers per patch

12 of 13 patches have a Reviewed-by or Acked-by.

PatchDaniel P. Berrangé
1/13R-b
2/13R-b
3/13R-b
4/13R-b
5/13R-b
6/13R-b
7/13
8/13R-b
9/13R-b
10/13R-b
11/13R-b
12/13R-b
13/13R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 00/13] crypto/luks: preparation for encryption key managment

Hi!

This patch series is the refactoring/preparation part of the former patch series I had sent which adds support for luks key management.

V2:
I addressed all the review comments
I also added another minor patch to improve an error messsage when trying to create too large file, for which I have an open bug that waits to be closed.
Its also is form of refactoring, and thus I guess it makes sense to include it here.

Best regards,
Maxim Levitsky

Maxim Levitsky (13):
block-crypto: misc refactoring
qcrypto-luks: rename some fields in QCryptoBlockLUKSHeader
qcrypto-luks: don't overwrite cipher_mode in header
qcrypto-luks: simplify masterkey and masterkey length
qcrypto-luks: pass keyslot index rather that pointer to the keyslot
qcrypto-luks: use the parsed encryption settings in QCryptoBlockLUKS
qcrypto-luks: purge unused error codes from open callback
qcrypto-luks: extract store and load header
qcrypto-luks: extract check and parse header
qcrypto-luks: extract store key function
qcrypto-luks: simplify the math used for keyslot locations
qcrypto-luks: more rigorous header checking
LUKS: better error message when creating too large files

 block/crypto.c      |   33 +-
 crypto/block-luks.c | 1025 +++++++++++++++++++++++++------------------
 2 files changed, 617 insertions(+), 441 deletions(-)
Signature · 1 line
2.17.2