Skip to content

mirror: Do not dereference invalid pointers

Max Reitz qemu-devel 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest4 patches 4 repliesIn review
  2. v24 patches 2 repliesSuperseded
  3. v14 patches 16 repliesSuperseded

Changes in v3 from the cover letter

- Patch 2: Use input visitor as proposed by Vladimir

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4mirror: Do not dereference invalid pointersblock/mirror.c+9 -40 replies
2/4blkdebug: Allow taking/unsharing permissionsblock/blkdebug.c qapi/block-core.json+103 -23 replies
3/4iotests: Add @error to wait_until_completedtests/qemu-iotests/iotests.py+12 -60 replies
4/4iotests: Add test for failing mirror completetests/qemu-iotests/041 tests/qemu-iotests/041.out+46 -20 replies

Reviews trailers per patch

3 of 4 patches have a Reviewed-by or Acked-by.

PatchJohn SnowVladimir Sementsov-Ogievskiy
1/4R-b R-b
2/4
3/4R-b R-b
4/4R-b R-b T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/4] mirror: Do not dereference invalid pointers

Hi,

v2’s cover letter should explain everything:

https://lists.nongnu.org/archive/html/qemu-block/2019-09/msg01079.html

v3:
- Patch 2: Use input visitor as proposed by Vladimir

git-backport-diff against v2:

Key:
[----] : patches are identical
[####] : number of functional differences between upstream/downstream patch [down] : patch is downstream-only
The flags [FC] indicate (F)unctional and (C)ontextual differences, respectively

001/4:[----] [--] 'mirror: Do not dereference invalid pointers' 002/4:[0041] [FC] 'blkdebug: Allow taking/unsharing permissions' 003/4:[----] [--] 'iotests: Add @error to wait_until_completed' 004/4:[----] [--] 'iotests: Add test for failing mirror complete'

Max Reitz (4):
mirror: Do not dereference invalid pointers
blkdebug: Allow taking/unsharing permissions
iotests: Add @error to wait_until_completed
iotests: Add test for failing mirror complete

 qapi/block-core.json          | 14 +++++-
 block/blkdebug.c              | 91 ++++++++++++++++++++++++++++++++++-
 block/mirror.c                | 13 +++--
 tests/qemu-iotests/041        | 44 +++++++++++++++++
 tests/qemu-iotests/041.out    |  4 +-
 tests/qemu-iotests/iotests.py | 18 ++++---
 6 files changed, 170 insertions(+), 14 deletions(-)
Signature · 1 line
2.21.0