Skip to content

active-mirror: support unaligned guest operations

Vladimir Sementsov-Ogievskiy qemu-devel 2 versions – Applied

Status from this message: Thanks, applied to my block branch:

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest5 patches 4 repliesApplied
  2. v14 patches 20 repliesSuperseded

Changes in v2 from the cover letter

01: new fix (do we need it for stable?)
02,03,05: add Max's r-b
04: fix bitmap handling
improve comments

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/5hbitmap: handle set/reset with zero lengthutil/hbitmap.c+8 -01 reply
2/5block/mirror: simplify do_sync_target_writeblock/mirror.c+28 -670 replies
3/5block/block-backend: add blk_co_pwritev_partblock/block-backend.c include/sysemu/block-backend.h+17 -40 replies
4/5block/mirror: support unaligned write in active mirrorblock/mirror.c+68 -31 reply
5/5Revert "mirror: Only mirror granularity-aligned chunks"block/mirror.c+0 -290 replies

Reviews trailers per patch

All 5 patches have a Reviewed-by or Acked-by.

PatchMax Reitz
1/5R-b
2/5R-b
3/5R-b
4/5R-b
5/5R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/5] active-mirror: support unaligned guest operations

Commit 9adc1cb49af8d fixed a bug about unaligned (to dirty bitmap granularity) guest writes (and discards) by simply requesting corresponding alignment on mirror-top filter. However forcing large alignment obviously decreases performance of unaligned requests.

So it's time for a new solution which is in 04. And 05 reverts 9adc1cb49af8d.

v2:
01: new fix (do we need it for stable?)
02,03,05: add Max's r-b
04: fix bitmap handling
improve comments

Vladimir Sementsov-Ogievskiy (5):
hbitmap: handle set/reset with zero length block/mirror: simplify do_sync_target_write block/block-backend: add blk_co_pwritev_part block/mirror: support unaligned write in active mirror Revert "mirror: Only mirror granularity-aligned chunks"

 include/sysemu/block-backend.h |   4 +
 block/block-backend.c          |  17 +++-
 block/mirror.c                 | 181 ++++++++++++++++-----------------
 util/hbitmap.c                 |   8 ++
 4 files changed, 114 insertions(+), 96 deletions(-)
Signature · 1 line
2.21.0