Skip to content

trace: Forbid trailing newline in event format

Philippe Mathieu-Daudé qemu-devel 2 versions – Applied

Status from this message: Thanks, applied (with Eric's typo fix) to my tracing tree:

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest2 patches 5 repliesApplied
  2. v12 patches 5 repliesSuperseded

Changes in v2 from the cover letter

- Use regex format (easier to review)
- Added R-b

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/2trace: Remove trailing newline in eventshw/misc/trace-events hw/scsi/trace-events hw/sd/trace-events +2 more+12 -124 replies
2/2trace: Forbid event format ending with newline characterdocs/devel/tracing.txt scripts/tracetool/__init__.py+5 -00 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchJohn SnowKevin Wolf
1/2R-b R-b
2/2R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [Qemu-devel] [PATCH v2 0/2] trace: Forbid trailing newline in event format

Hi Stefan,

I'v been confused by trailing newline in trace reports, so this series aims to fix this, by cleaning current formats and add a check to catch new one introduced.

v2:
- Use regex format (easier to review)
- Added R-b

Regards,

Phil.

Philippe Mathieu-Daudé (2):
trace: Remove trailing newline in events
trace: Forbid event format ending with newline character

 docs/devel/tracing.txt        |  2 ++
 hw/misc/trace-events          | 10 +++++-----
 hw/scsi/trace-events          |  2 +-
 hw/sd/trace-events            |  2 +-
 nbd/trace-events              |  4 ++--
 net/trace-events              |  6 +++---
 scripts/tracetool/__init__.py |  3 +++
 7 files changed, 17 insertions(+), 12 deletions(-)
Signature · 1 line
2.20.1