Skip to content

ls: convert to using statx when available

Jeff Layton ceph-devel linux-fsdevel 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v2 Latest2 patches 0 repliesNew

Changes in v2 from the cover letter

- add wrappers for stat_for_ino and fstat_for_ino, don't factor out loop detection
- style cleanups

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2stat: move struct statx to struct stat conversion routines to new headersrc/stat.c src/statx.h+55 -310 replies
2/2ls: use statx instead of stat when availablesrc/ls.c+99 -70 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [coreutils PATCH v2 0/2] ls: convert to using statx when available

v2:
- add wrappers for stat_for_ino and fstat_for_ino, don't factor out loop detection
- style cleanups

Sending to a wider distribution list this time, as this may encourage other filesystem maintainers to flesh out their statx implementations to take advantage of this.

Original patch description follows:

This patchset converts the ls command to use statx instead of stat when available. This allows ls to indicate interest in only certain inode metadata.

This is potentially a win on networked/clustered/distributed filesystems. In cases where we'd have to do a full, heavyweight stat() call we can now do a much lighter statx() call.

As a real-world example, consider a filesystem like CephFS where one client is actively writing to a file and another client does an ls --color in the same directory. --color means that we need to fetch the mode of the file.

Doing that with a stat() call means that we have to fetch the size and mtime in addition to the mode. The MDS in that situation will have to revoke caps in order to ensure that it has up-to-date values to report, which disrupts the writer.

This has a measurable affect on performance. I ran a fio sequential write test on one cephfs client and had a second client do "ls --color" in a tight loop on the directory that held the file:

Baseline -- no activity on the second client:

WRITE: bw=76.7MiB/s (80.4MB/s), 76.7MiB/s-76.7MiB/s (80.4MB/s-80.4MB/s), io=4600MiB (4824MB), run=60016-60016msec

Without this patch series, we see a noticable performance hit:

WRITE: bw=70.4MiB/s (73.9MB/s), 70.4MiB/s-70.4MiB/s (73.9MB/s-73.9MB/s), io=4228MiB (4433MB), run=60012-60012msec

With this patch series, we gain most of that ground back:

WRITE: bw=75.9MiB/s (79.6MB/s), 75.9MiB/s-75.9MiB/s (79.6MB/s-79.6MB/s), io=4555MiB (4776MB), run=60019-60019msec

Jeff Layton (2):
stat: move struct statx to struct stat conversion routines to new
header
ls: use statx instead of stat when available

 src/ls.c    | 106 ++++++++++++++++++++++++++++++++++++++++++++++++----
 src/stat.c  |  32 +---------------
 src/statx.h |  54 ++++++++++++++++++++++++++
 3 files changed, 154 insertions(+), 38 deletions(-)
 create mode 100644 src/statx.h
Signature · 1 line
2.21.0