Skip to content

drm: rework mmap() workflow

Gerd Hoffmann amd-gfx dri-devel lkml virtualization 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest11 patches 5 repliesIn review
  2. v311 patches 3 repliesSuperseded
  3. v211 patches 5 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v18 patches22 repliesSuperseded

Changes in v4 from the cover letter

- pick up a reviewed-by missed.
- add changelogs to patch commit msgs.
- make ttm_bo_mmap_vma_setup static.

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/11drm: add mmap() to drm_gem_object_funcsdrivers/gpu/drm/drm_gem.c drivers/gpu/drm/drm_prime.c include/drm/drm_gem.h+41 -90 replies
2/11drm/shmem: switch shmem helper to &drm_gem_object_funcs.mmapdrivers/gpu/drm/drm_gem_shmem_helper.c drivers/gpu/drm/panfrost/panfrost_gem.c drivers/gpu/drm/v3d/v3d_bo.c +2 more+15 -250 replies
3/11drm/shmem: drop VM_DONTDUMPdrivers/gpu/drm/drm_gem_shmem_helper.c+1 -10 replies
4/11drm/shmem: drop VM_IOdrivers/gpu/drm/drm_gem_shmem_helper.c+1 -10 replies
5/11drm/shmem: drop DEFINE_DRM_GEM_SHMEM_FOPSdrivers/gpu/drm/cirrus/cirrus.c drivers/gpu/drm/panfrost/panfrost_drv.c drivers/gpu/drm/tiny/gm12u320.c +3 more+5 -310 replies
6/11drm/ttm: factor out ttm_bo_mmap_vma_setupdrivers/gpu/drm/ttm/ttm_bo_vm.c+24 -224 replies
7/11drm/ttm: rename ttm_fbdev_mmapdrivers/gpu/drm/amd/amdgpu/amdgpu_object.c drivers/gpu/drm/ttm/ttm_bo_vm.c include/drm/ttm/ttm_bo_api.h+10 -130 replies
8/11drm/ttm: add drm_gem_ttm_mmap()drivers/gpu/drm/drm_gem_ttm_helper.c include/drm/drm_gem_ttm_helper.h+19 -01 reply
9/11drm/vram: switch vram helper to &drm_gem_object_funcs.mmap()drivers/gpu/drm/drm_gem_vram_helper.c include/drm/drm_gem_vram_helper.h+2 -410 replies
10/11drm/vram: drop verify_accessdrivers/gpu/drm/drm_gem_vram_helper.c+0 -220 replies
11/11drm/vram: drop DRM_VRAM_MM_FILE_OPERATIONSdrivers/gpu/drm/ast/ast_drv.c drivers/gpu/drm/bochs/bochs_drv.c drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c +3 more+5 -380 replies
11/11drm/vram: drop DRM_VRAM_MM_FILE_OPERATIONSdrivers/gpu/drm/ast/ast_drv.c drivers/gpu/drm/bochs/bochs_drv.c drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c +3 more+5 -380 replies

Reviews trailers per patch

All 12 patches have a Reviewed-by or Acked-by.

PatchDaniel VetterSteven PriceRob HerringThomas ZimmermannChristian König
1/11R-b
2/11R-b
3/11R-b
4/11R-b
5/11A-b
6/11R-b
7/11A-b
8/11R-b A-b
9/11R-b
10/11R-b
11/11R-b R-b
11/11R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.

Read the v4 thread

Cover letter [PATCH v4 00/11] drm: rework mmap() workflow

Add mmap callback to struct drm_gem_object_funcs, which is supposed to handle the vma setup. It will be used by both normal fops->mmap (via drm_gem_mmap_obj()) and prime mmap (via drm_gem_prime_mmap()).

For starters the shmem and vram helpers are switched over to the new workflow, to show things in action for review.

v4:
- pick up a reviewed-by missed.
- add changelogs to patch commit msgs.
- make ttm_bo_mmap_vma_setup static.

Gerd Hoffmann (11):
drm: add mmap() to drm_gem_object_funcs
drm/shmem: switch shmem helper to &drm_gem_object_funcs.mmap drm/shmem: drop VM_DONTDUMP
drm/shmem: drop VM_IO
drm/shmem: drop DEFINE_DRM_GEM_SHMEM_FOPS
drm/ttm: factor out ttm_bo_mmap_vma_setup
drm/ttm: rename ttm_fbdev_mmap
drm/ttm: add drm_gem_ttm_mmap()
drm/vram: switch vram helper to &drm_gem_object_funcs.mmap() drm/vram: drop verify_access
drm/vram: drop DRM_VRAM_MM_FILE_OPERATIONS

 include/drm/drm_gem.h                         | 14 +++++
 include/drm/drm_gem_shmem_helper.h            | 30 +---------
 include/drm/drm_gem_ttm_helper.h              |  2 +
 include/drm/drm_gem_vram_helper.h             | 25 ---------
 include/drm/ttm/ttm_bo_api.h                  | 10 ++--
 drivers/gpu/drm/amd/amdgpu/amdgpu_object.c    |  5 +-
 drivers/gpu/drm/ast/ast_drv.c                 |  5 +-
 drivers/gpu/drm/bochs/bochs_drv.c             |  5 +-
 drivers/gpu/drm/cirrus/cirrus.c               |  2 +-
 drivers/gpu/drm/drm_gem.c                     | 27 ++++++---
 drivers/gpu/drm/drm_gem_shmem_helper.c        | 28 ++++------
 drivers/gpu/drm/drm_gem_ttm_helper.c          | 17 ++++++
 drivers/gpu/drm/drm_gem_vram_helper.c         | 56 +------------------
 drivers/gpu/drm/drm_prime.c                   |  9 +++
 .../gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c   |  5 +-
 drivers/gpu/drm/mgag200/mgag200_drv.c         |  5 +-
 drivers/gpu/drm/panfrost/panfrost_drv.c       |  2 +-
 drivers/gpu/drm/panfrost/panfrost_gem.c       |  2 +-
 drivers/gpu/drm/tiny/gm12u320.c               |  2 +-
 drivers/gpu/drm/ttm/ttm_bo_vm.c               | 54 +++++++++---------
 drivers/gpu/drm/v3d/v3d_bo.c                  |  2 +-
 drivers/gpu/drm/v3d/v3d_drv.c                 |  2 +-
 drivers/gpu/drm/vboxvideo/vbox_drv.c          |  5 +-
 drivers/gpu/drm/virtio/virtgpu_drv.c          |  2 +-
 drivers/gpu/drm/virtio/virtgpu_object.c       |  2 +-
 25 files changed, 119 insertions(+), 199 deletions(-)
Signature · 6 lines
2.18.1

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel