Skip to content

x86: fix syscall function type mismatches

Sami Tolvanen lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 11 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4x86: use the correct function type in SYSCALL_DEFINE0arch/x86/include/asm/syscall_wrapper.h+12 -111 reply
2/4x86: use the correct function type for sys32_(rt_)sigreturnarch/x86/ia32/ia32_signal.c+2 -22 replies
3/4x86: use the correct function type for sys_ni_syscallarch/x86/entry/syscall_32.c arch/x86/entry/syscall_64.c arch/x86/entry/syscalls/syscall_32.tbl+21 -84 replies
4/4x86: fix function types in COND_SYSCALLarch/x86/include/asm/syscall_wrapper.h+16 -54 replies

Reviews trailers per patch

1 of 4 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchAndy Lutomirski
SeriesA-b A-b
1/4A-b
2/4
3/4
4/4

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/4] x86: fix syscall function type mismatches

This patch set changes x64 and ia32 syscall wrappers and related functions to use function types that match sys_call_ptr_t. This fixes indirect call mismatches with Control-Flow Integrity (CFI) checking.

Sami Tolvanen (4):
x86: use the correct function type in SYSCALL_DEFINE0
x86: use the correct function type for sys32_(rt_)sigreturn
x86: use the correct function type for sys_ni_syscall
x86: fix function types in COND_SYSCALL

 arch/x86/entry/syscall_32.c            | 13 ++++++--
 arch/x86/entry/syscall_64.c            | 12 +++++--
 arch/x86/entry/syscalls/syscall_32.tbl |  4 +--
 arch/x86/ia32/ia32_signal.c            |  4 +--
 arch/x86/include/asm/syscall_wrapper.h | 44 ++++++++++++++++----------
 5 files changed, 51 insertions(+), 26 deletions(-)
Signature · 1 line
2.23.0.237.gc6a4ce50a0-goog