Skip to content

devlink: allow devlink instances to change network namespace

Jiri Pirko netdev 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest15 patches 11 repliesIn review
  2. v215 patches 2 repliesSuperseded
  3. v115 patches 13 repliesSuperseded

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/15netdevsim: change fib accounting and limitations to be per-devicedrivers/net/netdevsim/dev.c drivers/net/netdevsim/fib.c drivers/net/netdevsim/netdev.c +1 more+114 -1281 reply
2/15net: fib_notifier: make FIB notifier per-netnsdrivers/net/ethernet/mellanox/mlx5/core/lag_mp.c drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c drivers/net/ethernet/rocker/rocker_main.c +12 more+78 -1050 replies
3/15net: fib_notifier: propagate possible error during fib notifier registrationinclude/net/ip_fib.h net/core/fib_rules.c net/ipv4/fib_notifier.c +3 more+71 -350 replies
4/15mlxsw: spectrum_router: Don't rely on missing extack to symbolize dumpdrivers/net/ethernet/mellanox/mlxsw/spectrum_router.c+1 -210 replies
5/15net: fib_notifier: propagate extack down to the notifier block callbackdrivers/net/ethernet/mellanox/mlx5/core/lag_mp.c drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c drivers/net/ethernet/rocker/rocker_main.c +17 more+105 -610 replies
6/15net: devlink: export devlink net getterinclude/net/devlink.h net/core/devlink.c+3 -10 replies
7/15mlxsw: spectrum: Take devlink net instead of init_netdrivers/net/ethernet/mellanox/mlxsw/core.h drivers/net/ethernet/mellanox/mlxsw/spectrum.c drivers/net/ethernet/mellanox/mlxsw/spectrum.h +3 more+34 -170 replies
8/15mlxsw: Register port netdevices into net of coredrivers/net/ethernet/mellanox/mlxsw/minimal.c drivers/net/ethernet/mellanox/mlxsw/spectrum.c drivers/net/ethernet/mellanox/mlxsw/switchx2.c+3 -00 replies
9/15mlxsw: Propagate extack down to register_fib_notifier()drivers/net/ethernet/mellanox/mlxsw/core.c drivers/net/ethernet/mellanox/mlxsw/core.h drivers/net/ethernet/mellanox/mlxsw/i2c.c +7 more+34 -210 replies
10/15netdevsim: add all ports in nsim_dev_create() and del them in destroy()drivers/net/netdevsim/dev.c+93 -821 reply
11/15netdevsim: implement proper devlink reloaddrivers/net/netdevsim/dev.c drivers/net/netdevsim/fib.c drivers/net/netdevsim/netdevsim.h+99 -574 replies
12/15netdevsim: register port netdevices into net of devicedrivers/net/netdevsim/netdev.c drivers/net/netdevsim/netdevsim.h+6 -02 replies
13/15netdevsim: take devlink net instead of init_netdrivers/net/netdevsim/fib.c+2 -21 reply
14/15net: devlink: allow to change namespaces during reloaddrivers/net/ethernet/mellanox/mlx4/main.c drivers/net/ethernet/mellanox/mlxsw/core.c drivers/net/netdevsim/dev.c +3 more+158 -111 reply
15/15selftests: netdevsim: add tests for devlink reload with resourcestools/testing/selftests/drivers/net/netdevsim/devlink.sh+119 -10 replies

Reviews trailers per patch

6 of 15 patches have a Reviewed-by or Acked-by.

PatchJakub Kicinski
1/15A-b
2/15
3/15
4/15
5/15
6/15
7/15
8/15
9/15
10/15A-b
11/15A-b
12/15A-b
13/15A-b
14/15A-b
15/15

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [patch net-next v3 00/15] devlink: allow devlink instances to change network namespace

From: Jiri Pirko <[email protected]>

Devlink from the beginning counts with network namespaces, but the instances has been fixed to init_net.

Implement change of network namespace as part of "devlink reload" procedure like this:

$ ip netns add testns1
$ devlink/devlink dev reload netdevsim/netdevsim10 netns testns1

This command reloads device "netdevsim10" into network namespace "testns1".

Note that "devlink reload" reinstantiates driver objects, effectively it reloads the driver instance, including possible hw reset etc. Newly created netdevices respect the network namespace of the parent devlink instance and according to that, they are created in target network namespace.

Driver is able to refuse to be reloaded into different namespace. That is the case of mlx4 right now.

FIB entries and rules are replayed during FIB notifier registration which is triggered during reload (driver instance init). FIB notifier is also registered to the target network namespace, that allows user to use netdevsim devlink resources to setup per-namespace limits of FIB entries and FIB rules. In fact, with multiple netdevsim instances in each network namespace, user might setup different limits. This maintains and extends current netdevsim resources behaviour.

Patch 1 prepares netdevsim code for the follow-up changes in the patchset. It does not change the behaviour, only moves pet-init_netns accounting to netdevsim instance, which is also in init_netns.

Patches 2-5 prepare the FIB notifier making it per-netns and to behave correctly upon error conditions.

Patch 6 just exports a devlink_net helper so it can be used in drivers.

Patches 7-9 do preparations in mlxsw driver.

Patches 10-13 do preparations in netdevsim driver, namely patch 12 implements proper devlink reload where the driver instance objects are actually re-created as they should be.

Patch 14 actually implements the possibility to reload into a different network namespace.

Patch 15 adds needed selftests for devlink reload into namespace for netdevsim driver.

Jiri Pirko (15):
netdevsim: change fib accounting and limitations to be per-device
net: fib_notifier: make FIB notifier per-netns
net: fib_notifier: propagate possible error during fib notifier
registration
mlxsw: spectrum_router: Don't rely on missing extack to symbolize dump
net: fib_notifier: propagate extack down to the notifier block
callback
net: devlink: export devlink net getter
mlxsw: spectrum: Take devlink net instead of init_net
mlxsw: Register port netdevices into net of core
mlxsw: Propagate extack down to register_fib_notifier()
netdevsim: add all ports in nsim_dev_create() and del them in
destroy()
netdevsim: implement proper devlink reload
netdevsim: register port netdevices into net of device
netdevsim: take devlink net instead of init_net
net: devlink: allow to change namespaces during reload
selftests: netdevsim: add tests for devlink reload with resources

 drivers/net/ethernet/mellanox/mlx4/main.c     |   6 +-
 .../net/ethernet/mellanox/mlx5/core/lag_mp.c  |   9 +-
 drivers/net/ethernet/mellanox/mlxsw/core.c    |  14 +-
 drivers/net/ethernet/mellanox/mlxsw/core.h    |  12 +-
 drivers/net/ethernet/mellanox/mlxsw/i2c.c     |   2 +-
 drivers/net/ethernet/mellanox/mlxsw/minimal.c |   4 +-
 drivers/net/ethernet/mellanox/mlxsw/pci.c     |   2 +-
 .../net/ethernet/mellanox/mlxsw/spectrum.c    |  22 +-
 .../net/ethernet/mellanox/mlxsw/spectrum.h    |   9 +-
 .../ethernet/mellanox/mlxsw/spectrum_nve.c    |   2 +-
 .../ethernet/mellanox/mlxsw/spectrum_router.c |  59 ++-
 .../mellanox/mlxsw/spectrum_switchdev.c       |   2 +-
 .../net/ethernet/mellanox/mlxsw/switchib.c    |   3 +-
 .../net/ethernet/mellanox/mlxsw/switchx2.c    |   4 +-
 drivers/net/ethernet/rocker/rocker_main.c     |   9 +-
 drivers/net/netdevsim/dev.c                   | 339 +++++++++---------
 drivers/net/netdevsim/fib.c                   | 175 +++++----
 drivers/net/netdevsim/netdev.c                |  10 +-
 drivers/net/netdevsim/netdevsim.h             |  15 +-
 include/linux/mroute_base.h                   |  28 +-
 include/net/devlink.h                         |   3 +-
 include/net/fib_notifier.h                    |  13 +-
 include/net/fib_rules.h                       |   3 +-
 include/net/ip6_fib.h                         |  11 +-
 include/net/ip_fib.h                          |  11 +-
 include/uapi/linux/devlink.h                  |   4 +
 net/core/devlink.c                            | 157 +++++++-
 net/core/fib_notifier.c                       |  95 +++--
 net/core/fib_rules.c                          |  23 +-
 net/ipv4/fib_notifier.c                       |  13 +-
 net/ipv4/fib_rules.c                          |   5 +-
 net/ipv4/fib_trie.c                           |  44 ++-
 net/ipv4/ipmr.c                               |  13 +-
 net/ipv4/ipmr_base.c                          |  30 +-
 net/ipv6/fib6_notifier.c                      |  11 +-
 net/ipv6/fib6_rules.c                         |   5 +-
 net/ipv6/ip6_fib.c                            |  50 ++-
 net/ipv6/ip6mr.c                              |  13 +-
 .../drivers/net/netdevsim/devlink.sh          | 120 ++++++-
 39 files changed, 864 insertions(+), 486 deletions(-)
Signature · 1 line
2.21.0