Skip to content

clone --filter=sparse:oid bugs

Jeff King git 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 4 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3t5616: test cloning/fetching with sparse:oid=<oid> filtert/t5616-partial-clone.sh+36 -00 replies
2/3list-objects-filter: delay parsing of sparse oidbuiltin/rev-list.c list-objects-filter-options.c list-objects-filter-options.h +2 more+14 -212 replies
3/3list-objects-filter: give a more specific error sparse parsing errorlist-objects-filter.c t/t5616-partial-clone.sh+4 -30 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/3] clone --filter=sparse:oid bugs
Quoted 2 lines · Jeff King

I'll work up what I sent earlier into a real patch, and include some of this discussion.

Here it is. I pulled Jon's tests out into their own patch (mostly because it makes it easier to give credit). Then patch 2 is my fix, and patch 3 is the message fixups he had done.

This replaces what's queued in js/partial-clone-sparse-blob.

[1/3]: t5616: test cloning/fetching with sparse:oid=<oid> filter [2/3]: list-objects-filter: delay parsing of sparse oid
[3/3]: list-objects-filter: give a more specific error sparse parsing error

 builtin/rev-list.c            |  4 ----
 list-objects-filter-options.c | 14 ++------------
 list-objects-filter-options.h |  2 +-
 list-objects-filter.c         | 14 +++++++++++---
 t/t5616-partial-clone.sh      | 36 +++++++++++++++++++++++++++++++++++
 5 files changed, 50 insertions(+), 20 deletions(-)