Skip to content

drm/nouveau: Miscellaneous fixes

Thierry Reding dri-devel nouveau 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest1 of 4 patches 0 repliesNew

1 of 4 patches is in this archive. The cover letter announces 4.

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
2/4drm/nouveau: prime: Extend DMA reservation object lockdrivers/gpu/drm/nouveau/nouveau_prime.c+14 -60 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/4] drm/nouveau: Miscellaneous fixes

From: Thierry Reding <[email protected]>

Hi Ben,

these are fixes for a couple of issues that I've been running into when testing on various Tegra boards. The first two patches fix up issues in the fix that I had sent out earlier to fix the regression introduced in drm-misc-next. The first one is critical because it avoids a BUG_ON as reported by Ilia, while the second is less critical, but restores the locking correctness (at least to the best of my knowledge).

Patch 3 is something that I think was also caused by the reservation object rework and is kind of a continuation of my earlier attempt to fix the VMA node sharing breakage. The current ordering between TTM and GEM teardown is causing a DEBUG_LOCKS_WARN_ON() because GEM cleanup already freed a mutex that TTM teardown will still want to use.

Lastly, patch 4 is quite uncritical, but it's a one-line change that is causing an ugly (but harmless) external memory address decode error on Tegra210 and later. It seems that for some reason clearing this register will cause a DMA operation to be started by the GPU. I've verified that it's tied to exactly that register write by modifying the value written to the register, and stalling for a couple of seconds after the register write. The address decode error reflects the value written into this register exactly and it always happens a couple of milliseconds after this write.

Thierry

Thierry Reding (4):
drm/nouveau: Fix fallout from reservation object rework drm/nouveau: prime: Extend DMA reservation object lock drm/nouveau: Fix ordering between TTM and GEM release drm/nouveau: gm20b: Avoid BAR1 teardown during init

 drivers/gpu/drm/nouveau/nouveau_bo.c          | 26 +++++++++++-------
 drivers/gpu/drm/nouveau/nouveau_bo.h          |  4 +--
 drivers/gpu/drm/nouveau/nouveau_gem.c         |  7 ++---
 drivers/gpu/drm/nouveau/nouveau_prime.c       | 27 ++++++++++++-------
 .../gpu/drm/nouveau/nvkm/subdev/bar/gm20b.c   |  1 -
 5 files changed, 39 insertions(+), 26 deletions(-)
Signature · 6 lines
2.23.0

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel