Skip to content

backup-top filter driver for backup

Vladimir Sementsov-Ogievskiy qemu-devel 4 versions – Applied

Status from this message: Thanks, applied to my block branch:

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v15 Latest5 patches 7 repliesApplied
  2. v1414 patches 1 replySuperseded
  3. v1315 patches 7 repliesApplied
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v122 patches7 repliesSuperseded

Patches in v15 Applied

#Subject and filesSizeRepliesApplied
1/5block/backup: move in-flight requests handling from backup to block-copyblock/backup.c block/block-copy.c include/block/block-copy.h+51 -521 reply
2/5block/backup: move write_flags calculation inside backup_job_createblock/backup.c+15 -151 reply
3/5block/block-copy: split block_copy_set_callbacks functionblock/backup.c block/block-copy.c include/block/block-copy.h+28 -151 reply
4/5block: introduce backup-top filter driverblock/Makefile.objs block/backup-top.c block/backup-top.h+323 -01 reply
5/5block/backup: use backup-top instead of write notifiersblock/backup-top.c block/backup.c block/block-copy.c +9 more+237 -2871 reply

Reviews trailers per patch

All 5 patches have a Reviewed-by or Acked-by.

PatchMax Reitz
1/5R-b
2/5R-b
3/5R-b
4/5R-b
5/5R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v15 thread

Cover letter [PATCH v15 0/5] backup-top filter driver for backup

Hi all!

These series introduce backup-top driver. It's a filter-node, which do copy-before-write operation. Mirror uses filter-node for handling guest writes, let's move to filter-node (from write-notifiers) for backup too.

Preparation patches are queued in Max's block branch:

Based-on: https://github.com/XanClic/qemu.git block

v15: use BdrvChildren in block-copy
01-03: new
04-05: a lot of changes, such as
04:
- add new parameters for creation
- prepare bcs creation
- add target child
- refactor bdrv_backup_top_append
- drop r-b
05:
- move block-copy to use BdrvChildren
- drop extra style fixing hunks
- iotest 141 output changed

v14: Drop range locks, keep old good in-flight requests waiting

12: new patch
14: use old request-waiting scheme instead of range locks

Vladimir Sementsov-Ogievskiy (5):
block/backup: move in-flight requests handling from backup to
block-copy
block/backup: move write_flags calculation inside backup_job_create block/block-copy: split block_copy_set_callbacks function
block: introduce backup-top filter driver
block/backup: use backup-top instead of write notifiers

 qapi/block-core.json       |   8 +-
 block/backup-top.h         |  41 +++++
 include/block/block-copy.h |  31 +++-
 include/block/block_int.h  |   1 +
 block/backup-top.c         | 276 +++++++++++++++++++++++++++++++++
 block/backup.c             | 147 +++++-------------
 block/block-copy.c         | 140 +++++++++--------
 block/replication.c        |   2 +-
 blockdev.c                 |   1 +
 block/Makefile.objs        |   1 +
 tests/qemu-iotests/056     |   8 +-
 tests/qemu-iotests/141.out |   2 +-
 tests/qemu-iotests/257     |   7 +-
 tests/qemu-iotests/257.out | 306 ++++++++++++++++++-------------------
 14 files changed, 628 insertions(+), 343 deletions(-)
 create mode 100644 block/backup-top.h
 create mode 100644 block/backup-top.c
Signature · 1 line
2.21.0