Skip to content

intel_cht_int33fe: Split code to USB Micro-B and Type-C variants

Yauhen Kharuzhy lkml platform-driver-x86 6 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest posting 2/21 patch 0 repliesNew
  2. v5 posting 1/21 patch 6 repliesSuperseded
  3. v41 patch 1 replySuperseded
Earlier versions · 3
VersionPostedPatchesRepliesStatus
v3 posting 2/20 of 1 patch0 repliesSuperseded
v3 posting 1/21 patch1 replySuperseded
v21 patch9 repliesSuperseded

Changes in v5 from the cover letter

- Spelling corrections in Kconfig, commit description and comments;
- Micro-B code: Remove warning at fuel gauge registration failure and use PTR_ERR_OR_ZERO() for simplicity.

Patches in v5 posting 2/2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/1platform/x86/intel_cht_int33fe: Split code to USB Micro-B and Type-C variantsdrivers/platform/x86/Kconfig drivers/platform/x86/Makefile drivers/platform/x86/intel_cht_int33fe_common.c +3 more+265 -720 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v5 yet.

Read the v5 thread

Cover letter [PATCH RESEND v5 0/1] intel_cht_int33fe: Split code to USB Micro-B and Type-C variants

Patch to support INT33FE ACPI pseudo-device on hardware with USB Micro-B connector.

v5:
- Spelling corrections in Kconfig, commit description and comments;
- Micro-B code: Remove warning at fuel gauge registration failure and use PTR_ERR_OR_ZERO() for simplicity.

v4:
- Micro-B variant: Don't print error to the kernel log if i2c_acpi_new_device() has returned -EPROBE_DEFER.

v3:
- Rename TypeB variant to Micro-B (we have only one such device for now and it has Micro-B connector)
- Rebase on current linus/master
- Remove empty lines and replace "TypeC" by "Type-C"

v2:
Instead of defining two separated modules with two separated config options, compile {common,typeb,typec} sources into one .ko module. Call needed variant-specific probe function based after of hardware type detection in common code.

Yauhen Kharuzhy (1):
platform/x86/intel_cht_int33fe: Split code to USB Micro-B and Type-C
variants

 drivers/platform/x86/Kconfig                  |  10 +-
 drivers/platform/x86/Makefile                 |   4 +
 .../platform/x86/intel_cht_int33fe_common.c   | 147 ++++++++++++++++++
 .../platform/x86/intel_cht_int33fe_common.h   |  41 +++++
 .../platform/x86/intel_cht_int33fe_microb.c   |  57 +++++++
 ...ht_int33fe.c => intel_cht_int33fe_typec.c} |  78 +---------
 6 files changed, 265 insertions(+), 72 deletions(-)
 create mode 100644 drivers/platform/x86/intel_cht_int33fe_common.c
 create mode 100644 drivers/platform/x86/intel_cht_int33fe_common.h
 create mode 100644 drivers/platform/x86/intel_cht_int33fe_microb.c
 rename drivers/platform/x86/{intel_cht_int33fe.c => intel_cht_int33fe_typec.c} (82%)
Signature · 1 line
2.23.0.rc1