Skip to content

net: dsa: mv88e6xxx: Add support for port mirroring

Iwan R Timmer netdev 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest2 patches 3 repliesIn review
  2. v22 patches 2 repliesSuperseded
  3. v11 patch 3 repliesSuperseded

Changes in v3 from the cover letter

- Use enum for egress traffic direction
- Keep track of egress ports on mv88e6390
- Move booleans in struct for better structure packing

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2net: dsa: mv88e6xxx: Split monitor port configurationdrivers/net/dsa/mv88e6xxx/chip.c drivers/net/dsa/mv88e6xxx/chip.h drivers/net/dsa/mv88e6xxx/global1.c +1 more+52 -161 reply
2/2net: dsa: mv88e6xxx: Add support for port mirroringdrivers/net/dsa/mv88e6xxx/chip.c drivers/net/dsa/mv88e6xxx/chip.h drivers/net/dsa/mv88e6xxx/global1.c +2 more+136 -41 reply

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchAndrew Lunn
1/2R-b
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH net-next v3 0/2] net: dsa: mv88e6xxx: Add support for port mirroring

This patch serie add support for port mirroring in the mv88e6xx switch driver. The first patch changes the set_egress_port function to allow different egress ports for egress and ingress traffic. The second patch adds the actual code for port mirroring support.

Tested on a 88E6176 with:

tc qdisc add dev wan0 clsact
tc filter add dev wan0 ingress matchall skip_sw \
action mirred egress mirror dev lan2
tc filter add dev wan0 egress matchall skip_sw \
action mirred egress mirror dev lan3

Changes in v3

- Use enum for egress traffic direction
- Keep track of egress ports on mv88e6390
- Move booleans in struct for better structure packing

Changes in v2

- Support mirroring egress and ingress traffic to different ports
- Check for invalid configurations when multiple ports are mirrored

Iwan R Timmer (2):
net: dsa: mv88e6xxx: Split monitor port configuration
net: dsa: mv88e6xxx: Add support for port mirroring

 drivers/net/dsa/mv88e6xxx/chip.c    | 85 ++++++++++++++++++++++++++++-
 drivers/net/dsa/mv88e6xxx/chip.h    | 15 ++++-
 drivers/net/dsa/mv88e6xxx/global1.c | 60 ++++++++++++++------
 drivers/net/dsa/mv88e6xxx/global1.h |  8 ++-
 drivers/net/dsa/mv88e6xxx/port.c    | 37 +++++++++++++
 drivers/net/dsa/mv88e6xxx/port.h    |  3 +
 6 files changed, 188 insertions(+), 20 deletions(-)
Signature · 1 line
2.23.0