Skip to content

Fix locktest and add lease testing to it

[email protected] fstests 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest posting 2/216 patches 3 repliesIn review
  2. v2 posting 1/211 of 16 patches 1 replySuperseded
  3. v113 patches 4 repliesSuperseded

Changes in v2 from the cover letter

Create a new option '-L' to run lease testing
Created 568 test script which shared common code with 131 Moved 2 patches earlier in the series
[PATCH V2 09/16] src/locktest: Clean up error output [PATCH V2 10/16] src/locktest: Audit all debug output
Added 3 patches
[PATCH V2 11/16] src/locktest: Add run() function [PATCH V2 15/16] common/locktest: Add common locktest functions [PATCH V2 16/16] generic/568: Add lease testing

Patches in v2 posting 2/2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/16src/locktest: Remove unnecessary sleepsrc/locktest.c+0 -50 replies
2/16src/locktest: Remove OPEN macrosrc/locktest.c+6 -30 replies
3/16src/locktest: Change command macro namessrc/locktest.c+273 -2730 replies
4/16src/locktest: Add get_cmd_strsrc/locktest.c+18 -120 replies
5/16src/locktest.c: Clean up client command passingsrc/locktest.c+23 -130 replies
6/16src/locktest.c: Fix return code if last test failssrc/locktest.c+9 -120 replies
7/16generic/131: Clean up pid variablestests/generic/131+5 -50 replies
8/16generic/131: Save stderr for debuggingtests/generic/131+45 -180 replies
9/16src/locktest: Clean up error outputsrc/locktest.c+22 -230 replies
10/16src/locktest: Audit all debug outputsrc/locktest.c tests/generic/131+13 -110 replies
11/16src/locktest: Add run() functionsrc/locktest.c+18 -120 replies
12/16src/locktest: Add simple lease testingsrc/locktest.c+106 -30 replies
13/16src/locktest: Add lease testing for basic signal receptionsrc/locktest.c+135 -20 replies
14/16src/locktest: Add truncate lease testssrc/locktest.c+50 -00 replies
15/16common/locktest: Add common locktest functionscommon/locktest tests/generic/131+95 -760 replies
16/16generic/568: Add lease testingcommon/locktest tests/generic/568 tests/generic/568.out +1 more+39 -00 replies

Reviews trailers per patch

10 of 16 patches have a Reviewed-by or Acked-by.

PatchJeff Layton
1/16R-b
2/16R-b
3/16R-b
4/16R-b
5/16R-b
6/16R-b
7/16R-b
8/16R-b
9/16R-b
10/16R-b
11/16
12/16
13/16
14/16
15/16
16/16

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH V2 00/16] Fix locktest and add lease testing to it

From: Ira Weiny <[email protected]>

Add lease tests[1] to locktest because they share so much code. Make running of lease tests separate as an '-L' option.

To make things cleaner update the lock test code and test script. This includes fixing a rather serious bug.

Finally update the error output to help identify any steps which fail during testing.

Changes from V1:
Create a new option '-L' to run lease testing
Created 568 test script which shared common code with 131 Moved 2 patches earlier in the series
[PATCH V2 09/16] src/locktest: Clean up error output [PATCH V2 10/16] src/locktest: Audit all debug output
Added 3 patches
[PATCH V2 11/16] src/locktest: Add run() function [PATCH V2 15/16] common/locktest: Add common locktest functions [PATCH V2 16/16] generic/568: Add lease testing

Ira Weiny (16):
src/locktest: Remove unnecessary sleep src/locktest: Remove OPEN macro
src/locktest: Change command macro names src/locktest: Add get_cmd_str
src/locktest.c: Clean up client command passing src/locktest.c: Fix return code if last test fails generic/131: Clean up pid variables
generic/131: Save stderr for debugging src/locktest: Clean up error output src/locktest: Audit all debug output src/locktest: Add run() function
src/locktest: Add simple lease testing src/locktest: Add lease testing for basic signal reception src/locktest: Add truncate lease tests common/locktest: Add common locktest functions generic/568: Add lease testing

 common/locktest       |  95 ++++
 src/locktest.c        | 999 +++++++++++++++++++++++++++---------------
 tests/generic/131     |  54 +--
 tests/generic/568     |  32 ++
 tests/generic/568.out |   2 +
 tests/generic/group   |   1 +
 6 files changed, 786 insertions(+), 397 deletions(-)
 create mode 100644 common/locktest
 create mode 100755 tests/generic/568
 create mode 100644 tests/generic/568.out
Signature · 1 line
2.20.1