Skip to content

error: auto propagated local_err part I

Vladimir Sementsov-Ogievskiy qemu-devel xen-devel 15 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v11 Latest8 patches 7 repliesIn review
  2. v109 patches 6 repliesSuperseded
  3. v910 patches 26 repliesSuperseded
Earlier versions · 12
VersionPostedPatchesRepliesStatus
v8 posting 2/210 patches32 repliesSuperseded
v7 posting 2/211 patches24 repliesSuperseded
v6 posting 3/311 patches14 repliesSuperseded
v8 posting 1/221 patches27 repliesSuperseded
v7 posting 1/221 patches19 repliesSuperseded
v6 posting 2/31 patch11 repliesSuperseded
v6 posting 1/31 patch7 repliesSuperseded
v5 RFC126 patches86 repliesSuperseded
v431 patches48 repliesSuperseded
v325 patches20 repliesSuperseded
v2 RFC9 patches17 repliesSuperseded
v1 RFC1 patch43 repliesSuperseded

Patches in v11 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8error: auto propagated local_errinclude/qapi/error.h+172 -331 reply
2/8scripts: Coccinelle script to use ERRP_AUTO_PROPAGATE()MAINTAINERS include/qapi/error.h scripts/coccinelle/auto-propagated-errp.cocci+341 -00 replies
3/8SD (Secure Card): introduce ERRP_AUTO_PROPAGATEhw/sd/sdhci-pci.c hw/sd/sdhci.c hw/sd/ssi-sd.c+17 -211 reply
4/8pflash: introduce ERRP_AUTO_PROPAGATEhw/block/pflash_cfi01.c hw/block/pflash_cfi02.c+6 -80 replies
5/8fw_cfg: introduce ERRP_AUTO_PROPAGATEhw/nvram/fw_cfg.c+6 -80 replies
6/8virtio-9p: introduce ERRP_AUTO_PROPAGATEhw/9pfs/9p-local.c hw/9pfs/9p.c+6 -70 replies
7/8nbd: introduce ERRP_AUTO_PROPAGATEblock/nbd.c include/block/nbd.h nbd/client.c +1 more+14 -42 replies
8/8xen: introduce ERRP_AUTO_PROPAGATEhw/block/dataplane/xen-block.c hw/block/xen-block.c hw/pci-host/xen_igd_pt.c +5 more+128 -1663 replies

Reviews trailers per patch

All 8 patches have a Reviewed-by or Acked-by.

PatchMarkus ArmbrusterPaul DurrantGreg KurzEric BlakePhilippe Mathieu-DaudéChristian Schoenebeck
1/8R-b R-b R-b
2/8R-b
3/8R-b
4/8R-b
5/8R-b
6/8A-b R-b
7/8R-b
8/8R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 6 reviewers.

Read the v11 thread

Cover letter [PATCH v11 0/8] error: auto propagated local_err part I

Based-on: <[email protected]>

v11: (based-on "[PATCH v2 00/44] Less clumsy error checking") 01: minor rebase of documentation, keep r-bs
02: - minor comment tweaks [Markus]
- use explicit file name in MAINTAINERS instead of pattern
- add Markus's r-b
03,07,08: rabase changes, drop r-bs

v11 is available at
https://src.openvz.org/scm/~vsementsov/qemu.git #tag up-auto-local-err-partI-v11
v10 is available at
https://src.openvz.org/scm/~vsementsov/qemu.git #tag up-auto-local-err-partI-v10

In these series, there is no commit-per-subsystem script, each generated commit is generated in separate.

Still, generating commands are very similar, and looks like

    sed -n '/^<Subsystem name>$/,/^$/{s/^F: //p}' MAINTAINERS | \
    xargs git ls-files | grep '\.[hc]$' | \
    xargs spatch \
        --sp-file scripts/coccinelle/auto-propagated-errp.cocci \
        --macro-file scripts/cocci-macro-file.h \
        --in-place --no-show-diff --max-width 80

Note, that in each generated commit, generation command is the only text, indented by 8 spaces in 'git log -1' output, so, to regenerate all commits (for example, after rebase, or change in coccinelle script), you may use the following command:

git rebase -x "sh -c \"git show --pretty= --name-only | xargs git checkout HEAD^ -- ; git reset; git log -1 | grep '^ ' | sh\"" HEAD~6

Which will start automated interactive rebase for generated patches, which will stop if generated patch changed
(you may do git commit --amend to apply updated generated changes).

Note:
git show --pretty= --name-only - lists files, changed in HEAD
git log -1 | grep '^ ' | sh - rerun generation command of HEAD

Check for compilation of changed .c files
git rebase -x "sh -c \"git show --pretty= --name-only | sed -n 's/\.c$/.o/p' | xargs make -j9\"" HEAD~6

Vladimir Sementsov-Ogievskiy (8):
error: auto propagated local_err
scripts: Coccinelle script to use ERRP_AUTO_PROPAGATE() SD (Secure Card): introduce ERRP_AUTO_PROPAGATE
pflash: introduce ERRP_AUTO_PROPAGATE
fw_cfg: introduce ERRP_AUTO_PROPAGATE
virtio-9p: introduce ERRP_AUTO_PROPAGATE
nbd: introduce ERRP_AUTO_PROPAGATE
xen: introduce ERRP_AUTO_PROPAGATE

 scripts/coccinelle/auto-propagated-errp.cocci | 337 ++++++++++++++++++
 include/block/nbd.h                           |   1 +
 include/qapi/error.h                          | 208 +++++++++--
 block/nbd.c                                   |   7 +-
 hw/9pfs/9p-local.c                            |  12 +-
 hw/9pfs/9p.c                                  |   1 +
 hw/block/dataplane/xen-block.c                |  17 +-
 hw/block/pflash_cfi01.c                       |   7 +-
 hw/block/pflash_cfi02.c                       |   7 +-
 hw/block/xen-block.c                          | 102 +++---
 hw/nvram/fw_cfg.c                             |  14 +-
 hw/pci-host/xen_igd_pt.c                      |   7 +-
 hw/sd/sdhci-pci.c                             |   7 +-
 hw/sd/sdhci.c                                 |  21 +-
 hw/sd/ssi-sd.c                                |  10 +-
 hw/xen/xen-backend.c                          |   7 +-
 hw/xen/xen-bus.c                              |  92 ++---
 hw/xen/xen-host-pci-device.c                  |  27 +-
 hw/xen/xen_pt.c                               |  25 +-
 hw/xen/xen_pt_config_init.c                   |  17 +-
 nbd/client.c                                  |   5 +
 nbd/server.c                                  |   5 +
 MAINTAINERS                                   |   1 +
 23 files changed, 690 insertions(+), 247 deletions(-)
 create mode 100644 scripts/coccinelle/auto-propagated-errp.cocci
Cc Eric Blake <[email protected]>
Cc Kevin Wolf <[email protected]>
Cc Max Reitz <[email protected]>
Cc Greg Kurz <[email protected]>
Cc Christian Schoenebeck <[email protected]>
Cc Stefan Hajnoczi <[email protected]>
Cc Stefano Stabellini <[email protected]>
Cc Anthony Perard <[email protected]>
Cc Paul Durrant <[email protected]>
Cc "Philippe Mathieu-Daudé" <[email protected]>
Cc Laszlo Ersek <[email protected]>
Cc Gerd Hoffmann <[email protected]>
Cc Markus Armbruster <[email protected]>
Cc Michael Roth <[email protected]>
Signature · 1 line
2.21.0