Skip to content

backlight: pwm_bl: optimizations and small fix for cie1913

Rasmus Villemoes dri-devel linux-fbdev linux-pwm lkml 2 versions – Applied

Status from this message: Applied, thanks.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest4 patches 5 repliesApplied
  2. v15 patches 11 repliesSuperseded

Changes in v2 from the cover letter

- Drop patch 5.
- Fix thinko in patch 4, otherwise no code change.
- Better changelog in patch 3.
- Add Daniel's Reviewed-By to the four patches.

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/4backlight: pwm_bl: fix cie1913 comments and constantdrivers/video/backlight/pwm_bl.c+9 -32 replies
2/4backlight: pwm_bl: eliminate a 64/32 divisiondrivers/video/backlight/pwm_bl.c+1 -11 reply
3/4backlight: pwm_bl: drop use of int_pow()drivers/video/backlight/pwm_bl.c+2 -11 reply
4/4backlight: pwm_bl: switch to power-of-2 base for fixed-point mathdrivers/video/backlight/pwm_bl.c+12 -101 reply

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchDaniel Thompson
1/4R-b
2/4R-b
3/4R-b
4/4R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/4] backlight: pwm_bl: optimizations and small fix for cie1913

These patches optimize the cie1913() implementation by using fewer 64 bit divisions and multiplications. It also contains a minor fix for the linear constant used.

v2:
- Drop patch 5.
- Fix thinko in patch 4, otherwise no code change.
- Better changelog in patch 3.
- Add Daniel's Reviewed-By to the four patches.

Daniel, I took the liberty of adding your R-B to patch 4 despite changing it a little to fix a thinko - I should add 1<<31 and not 1<<15. Please tell me if that was inappropriate.

Rasmus Villemoes (4):
backlight: pwm_bl: fix cie1913 comments and constant
backlight: pwm_bl: eliminate a 64/32 division
backlight: pwm_bl: drop use of int_pow()
backlight: pwm_bl: switch to power-of-2 base for fixed-point math

 drivers/video/backlight/pwm_bl.c | 29 +++++++++++++++++++----------
 1 file changed, 19 insertions(+), 10 deletions(-)
Signature · 1 line
2.20.1