Skip to content

RFC Add automated tests for shell lib

Petr Vorel ltp 1 version New

Get series with b4
b4 am 20190919142644.GA20853@x230

Versions newest first

  1. v2 RFC Latest1 patch 0 repliesNew

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/1Add automated tests for shell lib+0 -00 replies
1/1Add automated tests for shell lib+0 -03 replies
1/1Add automated tests for shell lib+0 -01 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [LTP] [RFC PATCH v2 0/1] Add automated tests for shell lib

Hi Christian,

Quoted 9 lines

Hi,

I am sorry that my reply took so long. Thank you very much for your comments which helped me to improve the code.
I have made an overhaul of the code based on your suggestions but an option to pass parameters to the tests is still not implemented.
I'm sending you what I have so far because it would help me when you could provide me more information regarding this.

Quoted 8 lines

I agree that it is difficult to find a way to process text the way needed here without disregarding the Linux Kernel Coding Style that asks for code which is transparent and easy to read when we only consider Shell commands. To address this issue I have drafted a Python script that might go in the tools folder and may perhaps be helpful in other cases as well. Since there are already Python files in the project it might be a valid option.

Thank you very much for your patience.

No problem, thanks continue for it.

I'm also not sure if we should put them into separate testcases/ directory. I'd put them into shell/ directory and rename test_sh_newlib.sh to run.sh or something simple.

BTW (nit, no hard feeling :) as lib/newlib_tests/test.*.sh are based on my previous work, you could might mention it in the change log. You updated them to have timeout output, so it's your work, (if not, it'd be better to send them as mine separate

Kind regards,
Petr