RFC Membarrier fixes and cleanups
Status from this message: I've picked them up (and fixed them up, they didn't apply to tip) and
Get series with b4
b4 am [email protected]Versions newest first
- v1 RFC Latest7 patches 6 repliesApplied
Patches in v1 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/7 | Fix: sched/membarrier: Private expedited registration checkkernel/ | +1 | 0 replies | |
| 2/7 | Cleanup: sched/membarrier: Remove redundant checkkernel/ | +2 | 0 replies | |
| 3/7 | Cleanup: sched/membarrier: Only sync_core before usermode for same mminclude/ | +2 | 0 replies | |
| 4/7 | Fix: sched/membarrier: p->mm->membarrier_state racy load (v4)fs/ include/ include/ +3 more | +184 | 2 replies | |
| 5/7 | selftests: sched/membarrier: Add multi-threaded testtools/ tools/ tools/ +2 more | +124 | 0 replies | |
| 6/7 | sched/membarrier: Skip IPIs when mm->mm_users == 1kernel/ | +5 | 0 replies | |
| 7/7 | sched/membarrier: Return -ENOMEM to userspace on memory allocation failurekernel/ | +19 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [RFC PATCH for 5.4 0/7] Membarrier fixes and cleanups
Hi,
Those series of fixes and cleanups are initially motivated by the report of race in membarrier, which can load p->mm->membarrier_state after mm has been freed (use-after-free).
Thanks,
Mathieu
Mathieu Desnoyers (7):
Fix: sched/membarrier: Private expedited registration check
Cleanup: sched/membarrier: Remove redundant check
Cleanup: sched/membarrier: Only sync_core before usermode for same mm
Fix: sched/membarrier: p->mm->membarrier_state racy load (v4)
selftests: sched/membarrier: Add multi-threaded test sched/membarrier: Skip IPIs when mm->mm_users == 1 sched/membarrier: Return -ENOMEM to userspace on memory allocation
failure
fs/exec.c | 2 +-
include/linux/mm_types.h | 14 +-
include/linux/sched/mm.h | 10 +-
kernel/sched/core.c | 4 +-
kernel/sched/membarrier.c | 236 +++++++++++-------
kernel/sched/sched.h | 34 +++
tools/testing/selftests/membarrier/.gitignore | 3 +-
tools/testing/selftests/membarrier/Makefile | 5 +-
...mbarrier_test.c => membarrier_test_impl.h} | 40 +--
.../membarrier/membarrier_test_multi_thread.c | 73 ++++++
.../membarrier_test_single_thread.c | 24 ++
11 files changed, 329 insertions(+), 116 deletions(-)
rename tools/testing/selftests/membarrier/{membarrier_test.c => membarrier_test_impl.h} (95%)
create mode 100644 tools/testing/selftests/membarrier/membarrier_test_multi_thread.c
create mode 100644 tools/testing/selftests/membarrier/membarrier_test_single_thread.cSignature · 1 line
2.17.1