Skip to content

nvme: double reset prevention

Keith Busch linux-nvme 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest5 patches 7 repliesIn review
  2. v35 patches 4 repliesSuperseded
  3. v26 patches 34 repliesSuperseded

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5nvme-pci: Free tagset if no IO queuesdrivers/nvme/host/pci.c+9 -20 replies
2/5nvme: Remove ADMIN_ONLY statedrivers/nvme/host/core.c drivers/nvme/host/fabrics.h drivers/nvme/host/nvme.h +1 more+11 -370 replies
3/5nvme: Restart request timers in resetting statedrivers/nvme/host/rdma.c drivers/nvme/host/tcp.c+16 -00 replies
4/5nvme: Prevent resets during paused controller statedrivers/nvme/host/core.c+25 -40 replies
5/5nvme: Wait for reset state when requireddrivers/nvme/host/core.c drivers/nvme/host/nvme.h drivers/nvme/host/pci.c+74 -171 reply

Reviews trailers per patch

4 of 5 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchJames SmartSagi GrimbergChristoph HellwigEdmund NadolskiBalbir Singh
SeriesR-b T-b
1/5R-b R-b R-b
2/5R-b R-b
3/5R-b R-b R-b
4/5
5/5A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.

Read the v4 thread

Cover letter [PATCHv4 0/5] nvme: double reset prevention

The main objective of this series is to prevent double resets. This sort of thing is known to have happened if a timeout occurs at roughly the same time as a user intiated reset, like through through PCIe's FLR.

The double reset could happen because the controller disabling had been occuring outside of the RESETTING state when we can't schedule the reset_work, which is to occur later. When another reset schedules in between these events, the controller ends up in the wrong state.

The end result of this series is simply to block subsequent resets by initializing the controller state to RESETTING without actually scheduling the reset_work.

v3 -> v4:

Renamed nvme_reset_schedule() to nvme_try_sched_reset_work() and documented when it may fail (hot remove). I'm open to suggestions for a better name.

Keith Busch (5):
nvme-pci: Free tagset if no IO queues
nvme: Remove ADMIN_ONLY state
nvme: Restart request timers in resetting state
nvme: Prevent resets during paused controller state
nvme: Wait for reset state when required

 drivers/nvme/host/core.c    | 91 +++++++++++++++++++++++++++----------
 drivers/nvme/host/fabrics.h |  3 +-
 drivers/nvme/host/nvme.h    |  5 +-
 drivers/nvme/host/pci.c     | 78 ++++++++++++++++++-------------
 drivers/nvme/host/rdma.c    |  8 ++++
 drivers/nvme/host/tcp.c     |  8 ++++
 6 files changed, 134 insertions(+), 59 deletions(-)
Signature · 7 lines
2.21.0


_______________________________________________
Linux-nvme mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-nvme