ipmi: Bug fixes, add new interfaces
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest15 patches 14 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/15 | ipmi: Fix watchdog NMI handlinghw/ hw/ | +4 | 1 reply | |
| 2/15 | ipmi: Fix the get watchdog commandhw/ | +2 | 1 reply | |
| 3/15 | ipmi: Generate an interrupt on watchdog pretimeout expiryhw/ | +3 | 1 reply | |
| 4/15 | tests:ipmi: Fix IPMI BT teststests/ tests/ | +5 | 0 replies | |
| 5/15 | qdev: Add a no default uuid propertyinclude/ | +7 | 1 reply | |
| 6/15 | ipmi: Add a UUID device propertyhw/ qemu-options.hx | +21 | 1 reply | |
| 7/15 | ipmi: Split out KCS-specific code from ISA KCS codehw/ hw/ hw/ +1 more | +505 | 0 replies | |
| 8/15 | ipmi: Split out BT-specific code from ISA BT codehw/ hw/ hw/ +1 more | +520 | 0 replies | |
| 9/15 | ipmi: Allow a size value to be passed for I/O spacehw/ hw/ hw/ +4 more | +44 | 0 replies | |
| 10/15 | smbios:ipmi: Ignore IPMI devices with no fwinfo functionhw/ | +3 | 0 replies | |
| 11/15 | ipmi: Add PCI IPMI interfacesdefault-configs/ hw/ hw/ +4 more | +309 | 0 replies | |
| 12/15 | ipmi: Add an SMBus IPMI interfacedefault-configs/ hw/ hw/ +2 more | +392 | 4 replies | |
| 13/15 | acpi: Add i2c serial bus CRS handlinghw/ include/ | +58 | 0 replies | |
| 14/15 | ipmi: Fix SSIF ACPI handling to use the right CRShw/ hw/ hw/ +1 more | +10 | 0 replies | |
| 15/15 | pc: Add an SMB0 ACPI device to q35hw/ hw/ hw/ +9 more | +28 | 0 replies |
Reviews trailers per patch
7 of 15 patches have a Reviewed-by or Acked-by.
| Patch | Philippe Mathieu-Daudé | Cédric Le Goater |
|---|---|---|
| 1/15 | R-b | |
| 2/15 | R-b | |
| 3/15 | R-b | |
| 4/15 | ||
| 5/15 | R-b | |
| 6/15 | R-b | |
| 7/15 | R-b | |
| 8/15 | R-b | |
| 9/15 | ||
| 10/15 | ||
| 11/15 | ||
| 12/15 | ||
| 13/15 | ||
| 14/15 | ||
| 15/15 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 00/15] ipmi: Bug fixes, add new interfaces
I haven't gotten a lot of commentary on this, but I assume that means that everything is ok. It's been posted a few times and the last time I received no issues, just a couple of reviews. I would like more review. But I'm not quite sure what to do about that, I've been hanging on to these changes far too long.
The following changes since commit a77d20bafcd4cb7684168a9b4c6dc2a321aaeb50:
Merge remote-tracking branch 'remotes/kraxel/tags/ui-20190919-pull-request' into staging (2019-09-19 17:16:07 +0100)
are available in the Git repository at:
https://github.com/cminyard/qemu.git tags/ipmi-for-release-2019-09-19
for you to fetch changes up to d9b74295c6528fd68cebdea116b283e46543b2a2:
pc: Add an SMB0 ACPI device to q35 (2019-09-19 14:41:58 -0500)
----------------------------------------------------------------
ipmi: Some bug fixes and new interfaces
Some bug fixes for the watchdog and hopeful the BT tests.
Change the IPMI UUID handling to give the user the ability to set it or not have it.
Add a PCI interface.
Add an SMBus interfaces.
-corey
----------------------------------------------------------------
Corey Minyard (15):
ipmi: Fix watchdog NMI handling
ipmi: Fix the get watchdog command
ipmi: Generate an interrupt on watchdog pretimeout expiry tests:ipmi: Fix IPMI BT tests
qdev: Add a no default uuid property
ipmi: Add a UUID device property
ipmi: Split out KCS-specific code from ISA KCS code
ipmi: Split out BT-specific code from ISA BT code
ipmi: Allow a size value to be passed for I/O space smbios:ipmi: Ignore IPMI devices with no fwinfo function
ipmi: Add PCI IPMI interfaces
ipmi: Add an SMBus IPMI interface
acpi: Add i2c serial bus CRS handling
ipmi: Fix SSIF ACPI handling to use the right CRS
pc: Add an SMB0 ACPI device to q35
default-configs/i386-softmmu.mak | 3 + hw/acpi/aml-build.c | 40 ++++ hw/acpi/ipmi-stub.c | 2 +- hw/acpi/ipmi.c | 13 +- hw/i386/Kconfig | 3 + hw/i386/acpi-build.c | 17 +- hw/i386/pc_piix.c | 12 +- hw/i386/pc_q35.c | 9 +- hw/ipmi/Kconfig | 15 ++ hw/ipmi/Makefile.objs | 5 +- hw/ipmi/ipmi.c | 6 +- hw/ipmi/ipmi_bmc_sim.c | 30 ++- hw/ipmi/ipmi_bt.c | 437 ++++++++++++++++++++++++++++++++++++++ hw/ipmi/ipmi_kcs.c | 423 +++++++++++++++++++++++++++++++++++++ hw/ipmi/isa_ipmi_bt.c | 443 ++------------------------------------- hw/ipmi/isa_ipmi_kcs.c | 419 ++---------------------------------- hw/ipmi/pci_ipmi_bt.c | 146 +++++++++++++ hw/ipmi/pci_ipmi_kcs.c | 146 +++++++++++++ hw/ipmi/smbus_ipmi.c | 384 +++++++++++++++++++++++++++++++++ hw/smbios/smbios_type_38.c | 3 + include/hw/acpi/aml-build.h | 18 ++ include/hw/acpi/ipmi.h | 2 +- include/hw/i386/pc.h | 2 + include/hw/ipmi/ipmi.h | 7 +- include/hw/ipmi/ipmi_bt.h | 73 +++++++ include/hw/ipmi/ipmi_kcs.h | 76 +++++++ include/hw/pci/pci.h | 1 + include/hw/qdev-properties.h | 7 + qemu-options.hx | 10 +- tests/Makefile.include | 3 +- tests/data/acpi/q35/DSDT | Bin 7841 -> 7879 bytes tests/data/acpi/q35/DSDT.bridge | Bin 7858 -> 7896 bytes tests/data/acpi/q35/DSDT.cphp | Bin 8304 -> 8342 bytes tests/data/acpi/q35/DSDT.dimmpxm | Bin 9494 -> 9532 bytes tests/data/acpi/q35/DSDT.ipmibt | Bin 7916 -> 7954 bytes tests/data/acpi/q35/DSDT.memhp | Bin 9200 -> 9238 bytes tests/data/acpi/q35/DSDT.mmio64 | Bin 8971 -> 9009 bytes tests/data/acpi/q35/DSDT.numamem | Bin 7847 -> 7885 bytes tests/ipmi-bt-test.c | 6 +- 39 files changed, 1902 insertions(+), 859 deletions(-) create mode 100644 hw/ipmi/ipmi_bt.c create mode 100644 hw/ipmi/ipmi_kcs.c create mode 100644 hw/ipmi/pci_ipmi_bt.c create mode 100644 hw/ipmi/pci_ipmi_kcs.c create mode 100644 hw/ipmi/smbus_ipmi.c create mode 100644 include/hw/ipmi/ipmi_bt.h create mode 100644 include/hw/ipmi/ipmi_kcs.h