Skip to content

Implement UNIT_CELL_SIZE control

Ricardo Ribalda Delgado linux-media lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v6 Latest7 patches 12 repliesIn review

Patches in v6 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7media: v4l2-core: Implement v4l2_ctrl_new_std_compounddrivers/media/v4l2-core/v4l2-ctrls.c include/media/v4l2-ctrls.h+64 -82 replies
2/7Documentation: v4l2_ctrl_new_std_compoundDocumentation/media/kapi/v4l2-controls.rst+9 -02 replies
3/7media: add V4L2_CTRL_TYPE_AREA control typedrivers/media/v4l2-core/v4l2-ctrls.c include/media/v4l2-ctrls.h include/uapi/linux/videodev2.h+68 -01 reply
4/7Documentation: media: Document V4L2_CTRL_TYPE_AREADocumentation/media/uapi/v4l/vidioc-queryctrl.rst+6 -02 replies
5/7media: add V4L2_CID_UNIT_CELL_SIZE controldrivers/media/v4l2-core/v4l2-ctrls.c include/uapi/linux/v4l2-controls.h+6 -00 replies
6/7Documentation: media: Describe V4L2_CID_UNIT_CELL_SIZEDocumentation/media/uapi/v4l/ext-ctrls-image-source.rst+9 -00 replies
7/7media: imx214: Add new control with V4L2_CID_UNIT_CELL_SIZEdrivers/media/i2c/imx214.c+12 -05 replies

Reviews trailers per patch

5 of 7 patches have a Reviewed-by or Acked-by.

PatchPhilipp ZabelJacopo Mondi
1/7
2/7R-b
3/7R-b
4/7R-b R-b
5/7R-b
6/7R-b
7/7

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v6 thread

Cover letter [PATCH v6 0/7] Implement UNIT_CELL_SIZE control

UNIT_CELL_SIZE is a control that represents the size of a cell (pixel). We required a bit of boilerplate to add this control :)
- New way to init compount controls
- New control type

Thanks to Hans, Jacopo and Philipp for your help.

You might want to see the series at my github repository if needed.

https://github.com/ribalda/linux/tree/unit-size-v6

v4, v5 of this patchset never reached the mailing list.

Ricardo Ribalda Delgado (7):
media: v4l2-core: Implement v4l2_ctrl_new_std_compound
Documentation: v4l2_ctrl_new_std_compound
media: add V4L2_CTRL_TYPE_AREA control type
Documentation: media: Document V4L2_CTRL_TYPE_AREA
media: add V4L2_CID_UNIT_CELL_SIZE control
Documentation: media: Describe V4L2_CID_UNIT_CELL_SIZE
media: imx214: Add new control with V4L2_CID_UNIT_CELL_SIZE

 Documentation/media/kapi/v4l2-controls.rst    |  9 +++
 .../media/uapi/v4l/ext-ctrls-image-source.rst |  9 +++
 .../media/uapi/v4l/vidioc-queryctrl.rst       |  6 ++
 drivers/media/i2c/imx214.c                    | 12 +++
 drivers/media/v4l2-core/v4l2-ctrls.c          | 76 +++++++++++++++++--
 include/media/v4l2-ctrls.h                    | 63 ++++++++++++++-
 include/uapi/linux/v4l2-controls.h            |  1 +
 include/uapi/linux/videodev2.h                |  6 ++
 8 files changed, 174 insertions(+), 8 deletions(-)
Signature · 1 line
2.23.0