Skip to content

ftgmac100: Support AST2600 RMII

Andrew Jeffery openbmc 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest8 patches 5 repliesIn review
  2. v16 patches 15 repliesSuperseded

Changes in v2 from the cover letter

* Support AST2500 RCLK as well.
* Add fixed RCLK clocks and describe correct parent clocks
* Re-order the patches to group clock and net changes.
* Update all the 2500- and 2600-based devicetrees

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8dt-bindings: clock: Add AST2500 RMII RCLK definitionsinclude/dt-bindings/clock/aspeed-clock.h+2 -00 replies
2/8dt-bindings: clock: Add AST2600 RMII RCLK gate definitionsinclude/dt-bindings/clock/ast2600-clock.h+5 -00 replies
3/8clk: aspeed: Add RMII RCLK gates for both AST2500 MACsdrivers/clk/clk-aspeed.c+26 -11 reply
4/8clk: ast2600: Add RMII RCLK gates for all four MACsdrivers/clk/clk-ast2600.c+46 -11 reply
5/8dt-bindings: net: ftgmac100: Document AST2600 compatibleDocumentation/devicetree/bindings/net/ftgmac100.txt+1 -00 replies
6/8dt-bindings: net: ftgmac100: Describe clock propertiesDocumentation/devicetree/bindings/net/ftgmac100.txt+6 -00 replies
7/8net: ftgmac100: Ungate RCLK for RMII on ASPEED MACsdrivers/net/ethernet/faraday/ftgmac100.c+28 -71 reply
8/8ARM: dts: aspeed: Add RCLK to MAC clocks for RMII interfacesarch/arm/boot/dts/aspeed-bmc-arm-stardragon4800-rep2.dts arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts arch/arm/boot/dts/aspeed-bmc-facebook-yamp.dts +13 more+51 -01 reply

Reviews trailers per patch

3 of 8 patches have a Reviewed-by or Acked-by.

PatchJoel Stanley
1/8
2/8
3/8R-b
4/8R-b
5/8
6/8
7/8R-b
8/8

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH linux dev-5.3 v2 0/8] ftgmac100: Support AST2600 RMII

Hello,

This series adds support for ungating RMII RCLK on the AST2500 and AST2600, enabling use of NCSI for the MACs if u-boot does not ungate the clock for us.

The patches have not yet been sent upstream, but I intend to do so once we're through the 5.4 merge window to avoid some of them disappearing into the net-next void.

v2:
* Support AST2500 RCLK as well.
* Add fixed RCLK clocks and describe correct parent clocks
* Re-order the patches to group clock and net changes.
* Update all the 2500- and 2600-based devicetrees

Tested by pinging a remote host on Tacoma (2600, u-boot does not configure RCLK) and Witherspoon (2500, manually disabled RCLK in u-boot before booting the kernel) hardware, and used QEMU to ensure the driver probes correctly on Palmetto (2400, no gate for RCLK).

Please review!

Andrew

Andrew Jeffery (8):
dt-bindings: clock: Add AST2500 RMII RCLK definitions
dt-bindings: clock: Add AST2600 RMII RCLK gate definitions
clk: aspeed: Add RMII RCLK gates for both AST2500 MACs
clk: ast2600: Add RMII RCLK gates for all four MACs
dt-bindings: net: ftgmac100: Document AST2600 compatible
dt-bindings: net: ftgmac100: Describe clock properties
net: ftgmac100: Ungate RCLK for RMII on ASPEED MACs
ARM: dts: aspeed: Add RCLK to MAC clocks for RMII interfaces

 .../devicetree/bindings/net/ftgmac100.txt     |  7 +++
 .../aspeed-bmc-arm-stardragon4800-rep2.dts    |  3 ++
 .../dts/aspeed-bmc-facebook-tiogapass.dts     |  3 ++
 .../arm/boot/dts/aspeed-bmc-facebook-yamp.dts |  3 ++
 .../boot/dts/aspeed-bmc-inspur-fp5280g2.dts   |  3 ++
 .../boot/dts/aspeed-bmc-inspur-on5263m5.dts   |  3 ++
 .../arm/boot/dts/aspeed-bmc-intel-s2600wf.dts |  3 ++
 arch/arm/boot/dts/aspeed-bmc-lenovo-hr630.dts |  3 ++
 .../boot/dts/aspeed-bmc-lenovo-hr855xg2.dts   |  3 ++
 arch/arm/boot/dts/aspeed-bmc-opp-lanyang.dts  |  3 ++
 arch/arm/boot/dts/aspeed-bmc-opp-mihawk.dts   |  3 ++
 arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts  |  3 ++
 arch/arm/boot/dts/aspeed-bmc-opp-swift.dts    |  3 ++
 arch/arm/boot/dts/aspeed-bmc-opp-tacoma.dts   |  3 ++
 .../boot/dts/aspeed-bmc-opp-witherspoon.dts   |  3 ++
 arch/arm/boot/dts/aspeed-bmc-opp-zaius.dts    |  3 ++
 .../boot/dts/aspeed-bmc-portwell-neptune.dts  |  6 +++
 drivers/clk/clk-aspeed.c                      | 27 ++++++++++-
 drivers/clk/clk-ast2600.c                     | 47 ++++++++++++++++++-
 drivers/net/ethernet/faraday/ftgmac100.c      | 35 +++++++++++---
 include/dt-bindings/clock/aspeed-clock.h      |  2 +
 include/dt-bindings/clock/ast2600-clock.h     |  5 ++
 22 files changed, 165 insertions(+), 9 deletions(-)
Signature · 1 line
2.20.1