posix-cpu-timers: Fix bogus permission checks
Get series with b4
b4 am [email protected]Versions newest first
- v2 Latest6 patches 2 repliesIn review
Changes in v2 from the cover letter
- Address the review comments from Frederic
- Actually return -EPERM when the permission check fails. See patch 6/6 for rationale
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/6 | posix-cpu-timers: Restrict timer_create() permissionskernel/ | +15 | 0 replies | |
| 2/6 | posix-cpu-timers: Restrict clock_gettime() permissionskernel/ | +12 | 0 replies | |
| 3/6 | posix-cpu-timers: Sanitize thread clock permissionskernel/ | +32 | 0 replies | |
| 4/6 | posix-cpu-timers: Make PID=0 and PID=self handling consistentkernel/ | +8 | 0 replies | |
| 5/6 | posix-cpu-timers: Return PTR_ERR() from lookup_task()kernel/ | +12 | 1 reply | |
| 6/6 | posix-cpu-timers: Return -EPERM if ptrace permission check failskernel/ | +1 | 1 reply |
Reviews trailers per patch
All 6 patches have a Reviewed-by or Acked-by.
| Patch | Frederic Weisbecker |
|---|---|
| 1/6 | R-b |
| 2/6 | R-b |
| 3/6 | R-b |
| 4/6 | R-b |
| 5/6 | R-b |
| 6/6 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [patch V2 0/6] posix-cpu-timers: Fix bogus permission checks
When cleaning up posix-cpu-timers I discovered that the permission checks for process clocks and process timers are completely bonkers. The only requirement is that the target PID is a group leader. Which means that any process can read the clocks and attach timers to any other process without priviledge restrictions.
That's just wrong because the clocks and timers can be used to observe behaviour and both reading the clocks and arming timers adds overhead and influences runtime performance of the target process.
Changes vs. V1:
- Address the review comments from Frederic
- Actually return -EPERM when the permission check fails. See patch 6/6 for rationale
V1 can be found here:
https://lore.kernel.org/r/[email protected]
I still did not come around to write self tests and won't do so in the next weeks as I'm traveling as of tomorrow and then going on vacation (finally) :)
Thanks,
tglx
--- posix-cpu-timers.c | 71 ++++++++++++++++++++++++++++++++++++----------------- 1 file changed, 49 insertions(+), 22 deletions(-)