Skip to content

s390x/mmu: DAT translation rewrite

David Hildenbrand qemu-devel 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest7 patches 5 repliesIn review
  2. v37 patches 9 repliesSuperseded
  3. v27 patches 16 repliesSuperseded

Changes in v4 from the cover letter

- "s390x/mmu: Inject PGM_ADDRESSING on bogus table addresses" -- s/goguous/bogus/
- "s390x/mmu: DAT table definition overhaul"
-- Fix SEGMENT_ENTRY_SFAA
-- Drop three unnecessary defines
- "s390x/mmu: Convert to non-recursive page table walk" -- Reorder "REGION_ENTRY_P" checks
-- Drop default cases that cannot be reached

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7s390x/mmu: Drop debug logging from MMU codetarget/s390x/mmu_helper.c+0 -510 replies
2/7s390x/mmu: Move DAT protection handling out of mmu_translate_asce()target/s390x/mmu_helper.c+16 -230 replies
3/7s390x/mmu: Inject DAT exceptions from a single placetarget/s390x/mmu_helper.c+17 -460 replies
4/7s390x/mmu: Inject PGM_ADDRESSING on bogus table addressestarget/s390x/mmu_helper.c+27 -40 replies
5/7s390x/mmu: Use TARGET_PAGE_MASK in mmu_translate_pte()target/s390x/mmu_helper.c+1 -10 replies
6/7s390x/mmu: DAT table definition overhaultarget/s390x/cpu.h target/s390x/mem_helper.c target/s390x/mmu_helper.c+84 -433 replies
7/7s390x/mmu: Convert to non-recursive page table walktarget/s390x/mmu_helper.c+108 -1001 reply

Reviews trailers per patch

All 7 patches have a Reviewed-by or Acked-by.

PatchThomas HuthRichard Henderson
1/7R-b R-b
2/7R-b R-b
3/7R-b R-b
4/7R-b R-b
5/7R-b R-b
6/7R-b A-b
7/7R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH v4 0/7] s390x/mmu: DAT translation rewrite

This is a split-up of:

    [PATCH-for-4.2 v1 3/9] s390x/mmu: DAT translation rewrite

Rebased on latest upstream changes.

v3 -> v4:
- "s390x/mmu: Inject PGM_ADDRESSING on bogus table addresses" -- s/goguous/bogus/
- "s390x/mmu: DAT table definition overhaul"
-- Fix SEGMENT_ENTRY_SFAA
-- Drop three unnecessary defines
- "s390x/mmu: Convert to non-recursive page table walk" -- Reorder "REGION_ENTRY_P" checks
-- Drop default cases that cannot be reached

v2 -> v3:
- "s390x/mmu: Inject PGM_ADDRESSING on boguous table addresses" -- Keep using cs->as
-- Make read_table_entry() return true/false
- "s390x/mmu: DAT table definition overhaul"
-- Added a comment where to find details about s390x and used definitions

v1 -> v2:
- Cleanup old code first, before switching to non-recursive handling
- Fix EDAT1 translation: I was missing the vaddr offset within the 1MB page.

David Hildenbrand (7):
s390x/mmu: Drop debug logging from MMU code
s390x/mmu: Move DAT protection handling out of mmu_translate_asce() s390x/mmu: Inject DAT exceptions from a single place s390x/mmu: Inject PGM_ADDRESSING on bogus table addresses s390x/mmu: Use TARGET_PAGE_MASK in mmu_translate_pte() s390x/mmu: DAT table definition overhaul
s390x/mmu: Convert to non-recursive page table walk

 target/s390x/cpu.h        |  78 +++++---
 target/s390x/mem_helper.c |  12 +-
 target/s390x/mmu_helper.c | 365 ++++++++++++++++----------------------
 3 files changed, 220 insertions(+), 235 deletions(-)
Signature · 1 line
2.21.0