iommu/amd: Locking Fixes
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest6 patches 15 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/6 | iommu/amd: Remove domain->updateddrivers/ drivers/ | +25 | 2 replies | |
| 2/6 | iommu/amd: Remove amd_iommu_devtable_lockdrivers/ | +6 | 3 replies | |
| 3/6 | iommu/amd: Take domain->lock for complete attach/detach pathdrivers/ | +26 | 2 replies | |
| 4/6 | iommu/amd: Check for busy devices earlier in attach_device()drivers/ | +7 | 2 replies | |
| 5/6 | iommu/amd: Lock dev_data in attach/detach code pathsdrivers/ drivers/ | +12 | 2 replies | |
| 6/6 | iommu/amd: Lock code paths traversing protection_domain->dev_listdrivers/ | +24 | 2 replies |
Reviews trailers per patch
All 6 patches have a Reviewed-by or Acked-by.
| Patch | Filippo Sironi | Jerry Snitselaar |
|---|---|---|
| 1/6 | R-b | R-b |
| 2/6 | R-b | R-b |
| 3/6 | R-b | R-b |
| 4/6 | R-b | R-b |
| 5/6 | R-b | R-b |
| 6/6 | R-b | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 0/6] iommu/amd: Locking Fixes
Hi,
here are a couple of fixes for the amd iommu driver to fix a few locking issues around protection-domains. Main problem was that some traversals of ->dev_list were not locked in any form, causing potential race conditions.
But there are more issues fixed here, for example the racy access to protection_domain->updated and races in the attach/detach_device code paths.
Changes are boot-tested with lockdep enabled, looked all good so far.
Please review.
Thanks,
Joerg
Joerg Roedel (6):
iommu/amd: Remove domain->updated
iommu/amd: Remove amd_iommu_devtable_lock
iommu/amd: Take domain->lock for complete attach/detach path iommu/amd: Check for busy devices earlier in attach_device() iommu/amd: Lock dev_data in attach/detach code paths iommu/amd: Lock code paths traversing protection_domain->dev_list
drivers/iommu/amd_iommu.c | 166 ++++++++++++++++---------------- drivers/iommu/amd_iommu_types.h | 4 +- 2 files changed, 85 insertions(+), 85 deletions(-)
Signature · 6 lines
2.17.1 _______________________________________________ iommu mailing list [email protected] https://lists.linuxfoundation.org/mailman/listinfo/iommu