lib: introduce copy_struct_from_user() helper
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v4 Latest4 patches 10 repliesIn review
- v34 patches 0 repliesSuperseded
- v24 patches 5 repliesSuperseded
Earlier versions · 1
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v1 | 4 patches | 11 replies | Superseded |
Changes in v4 from the cover letter
* __always_inline copy_struct_from_user(). [Kees Cook]
* Rework test_user_copy.ko changes. [Kees Cook]
v3: <https://lore.kernel.org/lkml/[email protected]/>
Patches in v4 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/4 | lib: introduce copy_struct_from_user() helperinclude/ include/ lib/ +2 more | +263 | 20 replies | |
| 2/4 | clone3: switch to copy_struct_from_user()include/ kernel/ | +9 | 1 reply | |
| 3/4 | sched_setattr: switch to copy_struct_from_user()kernel/ | +7 | 1 reply | |
| 4/4 | perf_event_open: switch to copy_struct_from_user()kernel/ | +9 | 1 reply |
Reviews trailers per patch
All 4 patches have a Reviewed-by or Acked-by.
| Patch | Kees Cook | Christian Brauner | Aleksa Sarai |
|---|---|---|---|
| 1/4 | R-b | R-b A-b | R-b |
| 2/4 | R-b | R-b | |
| 3/4 | R-b | R-b | |
| 4/4 | R-b | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [PATCH v4 0/4] lib: introduce copy_struct_from_user() helper
Patch changelog:
v4:
* __always_inline copy_struct_from_user(). [Kees Cook]
* Rework test_user_copy.ko changes. [Kees Cook]
v3: <https://lore.kernel.org/lkml/[email protected]/>
<https://lore.kernel.org/lkml/[email protected]/>
v2: <https://lore.kernel.org/lkml/[email protected]/>
v1: <https://lore.kernel.org/lkml/[email protected]/>
This series was split off from the openat2(2) syscall discussion[1]. However, the copy_struct_to_user() helper has been dropped, because after some discussion it appears that there is no really obvious semantics for how copy_struct_to_user() should work on mixed-vintages (for instance, whether [2] is the correct semantics for all syscalls).
A common pattern for syscall extensions is increasing the size of a struct passed from userspace, such that the zero-value of the new fields result in the old kernel behaviour (allowing for a mix of userspace and kernel vintages to operate on one another in most cases).
Previously there was no common lib/ function that implemented the necessary extension-checking semantics (and different syscalls implemented them slightly differently or incompletely[3]). This series implements the helper and ports several syscalls to use it.
Some in-kernel selftests are included in this patch. More complete self-tests for copy_struct_from_user() are included in the openat2() patchset.
[1]: https://lore.kernel.org/lkml/[email protected]/
[2]: commit 1251201c0d34 ("sched/core: Fix uclamp ABI bug, clean up and
robustify sched_read_attr() ABI logic and code")
[3]: For instance {sched_setattr,perf_event_open,clone3}(2) all do do
similar checks to copy_struct_from_user() while rt_sigprocmask(2) always rejects differently-sized struct arguments.
Aleksa Sarai (4):
lib: introduce copy_struct_from_user() helper
clone3: switch to copy_struct_from_user()
sched_setattr: switch to copy_struct_from_user()
perf_event_open: switch to copy_struct_from_user()
include/linux/bitops.h | 7 ++ include/linux/uaccess.h | 70 +++++++++++++++++++ include/uapi/linux/sched.h | 2 + kernel/events/core.c | 47 +++---------- kernel/fork.c | 34 ++-------- kernel/sched/core.c | 43 ++---------- lib/strnlen_user.c | 8 +-- lib/test_user_copy.c | 136 +++++++++++++++++++++++++++++++++++-- lib/usercopy.c | 55 +++++++++++++++ 9 files changed, 288 insertions(+), 114 deletions(-)
Signature · 1 line
2.23.0