Skip to content

kdb: Fixes for btc

Douglas Anderson lkml 1 version Applied

Status from this message: Applied.

Get series with b4
b4 am [email protected]

Versions newest first

  1. v3 Latest4 patches 9 repliesApplied

Changes in v3 from the cover letter

- Patch ("Remove unused DCPU_SSTEP definition") new for v3.
- Patch ("kdb: Remove unused "argcount" param from...") new for v3.
- Patch ("kdb: Fix "btc <cpu>" crash if the CPU...") new for v3.
- Use exception state instead of new dbg_slave_dumpstack_cpu var.
- Move horror to debug core, cleaning up control flow.
- Avoid need for timeout by only waiting for CPUs marked as slaves.

Patches in v3 Applied

#Subject and filesSizeRepliesApplied
1/4kgdb: Remove unused DCPU_SSTEP definitionkernel/debug/debug_core.h+0 -11 reply
2/4kdb: Remove unused "argcount" param from kdb_bt1(); make btaprompt boolkernel/debug/kdb/kdb_bt.c+6 -80 replies
3/4kdb: Fix "btc <cpu>" crash if the CPU didn't round upkernel/debug/kdb/kdb_bt.c+34 -276 replies
4/4kdb: Fix stack crawling on 'running' CPUs that aren't the masterkernel/debug/debug_core.c kernel/debug/debug_core.h kernel/debug/kdb/kdb_bt.c+43 -120 replies

Reviews trailers per patch

1 of 4 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchJason WesselWill Deacon
SeriesA-b
1/4A-b
2/4
3/4
4/4

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/4] kdb: Fixes for btc

This series has a few kdb fixes for back tracing on CPUs. The previous version[1] had only one patch, but while making v3 I found a few cleanups that made sense to break into other pieces.

As with all things kdb / kgdb, this patch set tries to inch us towards a better state of the world but doesn't attempt to solve all known problems.

Please enjoy.

[1] https://lore.kernel.org/r/[email protected]

Changes in v3:
- Patch ("Remove unused DCPU_SSTEP definition") new for v3.
- Patch ("kdb: Remove unused "argcount" param from...") new for v3.
- Patch ("kdb: Fix "btc <cpu>" crash if the CPU...") new for v3.
- Use exception state instead of new dbg_slave_dumpstack_cpu var.
- Move horror to debug core, cleaning up control flow.
- Avoid need for timeout by only waiting for CPUs marked as slaves.

Changes in v2:
- Totally new approach; now arch agnostic.

Douglas Anderson (4):
kgdb: Remove unused DCPU_SSTEP definition
kdb: Remove unused "argcount" param from kdb_bt1(); make btaprompt
bool
kdb: Fix "btc <cpu>" crash if the CPU didn't round up
kdb: Fix stack crawling on 'running' CPUs that aren't the master

 kernel/debug/debug_core.c | 34 ++++++++++++++
 kernel/debug/debug_core.h |  3 +-
 kernel/debug/kdb/kdb_bt.c | 94 +++++++++++++++++++--------------------
 3 files changed, 83 insertions(+), 48 deletions(-)
Signature · 1 line
2.23.0.351.gc4317032e6-goog