Skip to content

new PTP ioctl fixes

Jacob Keller intel-wired-lan netdev 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest7 patches 19 repliesIn review
  2. v22 patches 5 repliesApplied
  3. v12 patches 0 repliesSuperseded

Changes in v3 from the cover letter

* Split the external timestamp changes to separate patches per-driver
* Change the check for external timestamp flags to always accept all three current flags.
* Add cc for authors of the PTP support, hopefully receiving feedback

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7ptp: correctly disable flags on old ioctlsdrivers/ptp/ptp_chardev.c include/uapi/linux/ptp_clock.h+24 -21 reply
2/7net: reject PTP periodic output requests with unsupported flagsdrivers/net/ethernet/broadcom/tg3.c drivers/net/ethernet/intel/igb/igb_ptp.c drivers/net/ethernet/mellanox/mlx5/core/lib/clock.c +4 more+27 -02 replies
3/7mv88e6xxx: reject unsupported external timestamp flagsdrivers/net/dsa/mv88e6xxx/ptp.c+6 -04 replies
4/7dp83640: reject unsupported external timestamp flagsdrivers/net/phy/dp83640.c+5 -01 reply
5/7igb: reject unsupported external timestamp flagsdrivers/net/ethernet/intel/igb/igb_ptp.c+6 -02 replies
6/7mlx5: reject unsupported external timestamp flagsdrivers/net/ethernet/mellanox/mlx5/core/lib/clock.c+6 -01 reply
7/7renesas: reject unsupported external timestamp flagsdrivers/net/ethernet/renesas/ravb_ptp.c+6 -02 replies

Reviews trailers per patch

6 of 7 patches have a Reviewed-by or Acked-by.

PatchSergei ShtylyovAaron BrownRichard Cochran
1/7T-b
2/7T-b R-b
3/7R-b
4/7R-b
5/7T-b R-b
6/7R-b
7/7R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v3 thread

Cover letter [net-next v3 0/7] new PTP ioctl fixes

This series contains patches to fix the various drivers which implemented external pin input/output support. The drivers did not explicitly reject unknown/unsupported flags.

Changes since v2:
* Split the external timestamp changes to separate patches per-driver
* Change the check for external timestamp flags to always accept all three current flags.
* Add cc for authors of the PTP support, hopefully receiving feedback

Jacob Keller (7):
ptp: correctly disable flags on old ioctls
net: reject PTP periodic output requests with unsupported flags
mv88e6xxx: reject unsupported external timestamp flags
dp83640: reject unsupported external timestamp flags
igb: reject unsupported external timestamp flags
mlx5: reject unsupported external timestamp flags
renesas: reject unsupported external timestamp flags

 drivers/net/dsa/mv88e6xxx/ptp.c               |  6 +++++
 drivers/net/ethernet/broadcom/tg3.c           |  4 ++++
 drivers/net/ethernet/intel/igb/igb_ptp.c      | 10 +++++++++
 .../ethernet/mellanox/mlx5/core/lib/clock.c   | 10 +++++++++
 drivers/net/ethernet/microchip/lan743x_ptp.c  |  4 ++++
 drivers/net/ethernet/renesas/ravb_ptp.c       | 10 +++++++++
 .../net/ethernet/stmicro/stmmac/stmmac_ptp.c  |  4 ++++
 drivers/net/phy/dp83640.c                     |  8 +++++++
 drivers/ptp/ptp_chardev.c                     |  4 ++--
 include/uapi/linux/ptp_clock.h                | 22 +++++++++++++++++++
 10 files changed, 80 insertions(+), 2 deletions(-)
Signature · 1 line
2.23.0.245.gf157bbb9169d