Skip to content

USB: usblcd: disconnect fix and locking clean ups

Johan Hovold linux-usb stable 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4USB: usblcd: fix I/O after disconnectdrivers/usb/misc/usblcd.c+31 -20 replies
1/4USB: usblcd: fix I/O after disconnectdrivers/usb/misc/usblcd.c+31 -20 replies
2/4USB: usblcd: drop redundant disconnect mutexdrivers/usb/misc/usblcd.c+1 -170 replies
2/4USB: usblcd: drop redundant disconnect mutexdrivers/usb/misc/usblcd.c+1 -170 replies
3/4USB: usblcd: drop redundant lcd mutexdrivers/usb/misc/usblcd.c+0 -70 replies
3/4USB: usblcd: drop redundant lcd mutexdrivers/usb/misc/usblcd.c+0 -70 replies
4/4USB: usblcd: use pr_err()drivers/usb/misc/usblcd.c+1 -10 replies
4/4USB: usblcd: use pr_err()drivers/usb/misc/usblcd.c+1 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/4] USB: usblcd: disconnect fix and locking clean ups

This series fixes a failure to stop I/O on disconnect() in the usblcd driver. Turns out there was a lot of legacy cruft in this driver which could simply be removed.

The first patch is marked for stable and could go into v5.4 while the rest is v5.5 material. Posting all at once for completeness.

I was tempted to rip out the custom ioctls() used to retrieve the driver version and bcdDevice (sic!), but decided to leave them in. I doubt anyone would miss them though so perhaps we should give it a go?

Tested using a mockup device.

Johan

Johan Hovold (4):
USB: usblcd: fix I/O after disconnect
USB: usblcd: drop redundant disconnect mutex
USB: usblcd: drop redundant lcd mutex
USB: usblcd: use pr_err()

 drivers/usb/misc/usblcd.c | 60 +++++++++++++++++++++------------------
 1 file changed, 33 insertions(+), 27 deletions(-)
Signature · 1 line
2.23.0