Skip to content

drm/lima: simplify driver by using more drm helpers

Qiang Yu dri-devel 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest3 patches 2 repliesIn review
  2. v36 patches 0 repliesSuperseded
  3. v26 patches 6 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v16 patches6 repliesSuperseded

Changes in v4 from the cover letter

Drop drm_gem_objects_lookup refine patches.

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3drm/lima: use drm_gem_shmem_helpersdrivers/gpu/drm/lima/Kconfig drivers/gpu/drm/lima/Makefile drivers/gpu/drm/lima/lima_drv.c +9 more+145 -3600 replies
2/3drm/lima: use drm_gem_(un)lock_reservationsdrivers/gpu/drm/lima/lima_gem.c+6 -580 replies
3/3drm/lima: add __GFP_NOWARN flag to all dma_alloc_wcdrivers/gpu/drm/lima/lima_device.c drivers/gpu/drm/lima/lima_vm.c+3 -30 replies

Reviews trailers per patch

None of the 3 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchVasily Khoruzhick
SeriesR-b
1/3
2/3
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH v4 0/3] drm/lima: simplify driver by using more drm helpers

By using shared drm helpers:
1. drm_gem_(un)lock_reservations
2. drm_gem_shmem_helpers
we can simplify lima driver a lot and benifit from updates to these functions.

Patch series is based on drm-misc-next branch

v2:
Add drm_gem_objects_lookup_user and use it for driver which pass user GEM handles in contious array.

v3:
improve commit comment.

v4:
Drop drm_gem_objects_lookup refine patches.

Qiang Yu (3):
drm/lima: use drm_gem_shmem_helpers drm/lima: use drm_gem_(un)lock_reservations drm/lima: add __GFP_NOWARN flag to all dma_alloc_wc

 drivers/gpu/drm/lima/Kconfig          |   1 +
 drivers/gpu/drm/lima/Makefile         |   4 +-
 drivers/gpu/drm/lima/lima_device.c    |   2 +-
 drivers/gpu/drm/lima/lima_drv.c       |  22 +--
 drivers/gpu/drm/lima/lima_gem.c       | 195 ++++++++++----------------
 drivers/gpu/drm/lima/lima_gem.h       |  32 ++++-
 drivers/gpu/drm/lima/lima_gem_prime.c |  46 ------
 drivers/gpu/drm/lima/lima_gem_prime.h |  13 --
 drivers/gpu/drm/lima/lima_mmu.c       |   1 -
 drivers/gpu/drm/lima/lima_object.c    | 119 ----------------
 drivers/gpu/drm/lima/lima_object.h    |  35 -----
 drivers/gpu/drm/lima/lima_sched.c     |   6 +-
 drivers/gpu/drm/lima/lima_vm.c        |  87 ++++++------
 13 files changed, 148 insertions(+), 415 deletions(-)
 delete mode 100644 drivers/gpu/drm/lima/lima_gem_prime.c
 delete mode 100644 drivers/gpu/drm/lima/lima_gem_prime.h
 delete mode 100644 drivers/gpu/drm/lima/lima_object.c
 delete mode 100644 drivers/gpu/drm/lima/lima_object.h
Signature · 6 lines
2.17.1

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel