Skip to content

iotests: Allow ./check -o data_file

Max Reitz qemu-devel 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest22 patches 5 repliesIn review
  2. v221 patches 25 repliesSuperseded
  3. v118 patches 41 repliesSuperseded

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/22iotests: s/qocw2/qcow2/tests/qemu-iotests/060 tests/qemu-iotests/061 tests/qemu-iotests/062 +5 more+8 -82 replies
2/22iotests/qcow2.py: Add dump-header-extstests/qemu-iotests/qcow2.py+5 -00 replies
3/22iotests/qcow2.py: Split feature fields into bitstests/qemu-iotests/031.out tests/qemu-iotests/036.out tests/qemu-iotests/039.out +4 more+99 -890 replies
4/22iotests: Add _filter_json_filenametests/qemu-iotests/common.filter+24 -00 replies
5/22iotests: Filter refcount_order in 036tests/qemu-iotests/036 tests/qemu-iotests/036.out+6 -510 replies
6/22iotests: Replace IMGOPTS by _unsupported_imgoptstests/qemu-iotests/036 tests/qemu-iotests/060 tests/qemu-iotests/062 +3 more+11 -90 replies
7/22iotests: Drop compat=1.1 in 050tests/qemu-iotests/050+0 -40 replies
8/22iotests: Let _make_test_img parse its parameterstests/qemu-iotests/common.rc+20 -80 replies
9/22iotests: Add -o and --no-opts to _make_test_imgtests/qemu-iotests/common.rc+13 -00 replies
10/22iotests: Inject space into -ocompat=0.10 in 051tests/qemu-iotests/051+1 -10 replies
11/22iotests: Replace IMGOPTS= by -otests/qemu-iotests/031 tests/qemu-iotests/039 tests/qemu-iotests/059 +19 more+100 -1010 replies
12/22iotests: Replace IMGOPTS='' by --no-optstests/qemu-iotests/071 tests/qemu-iotests/174 tests/qemu-iotests/178 +2 more+9 -90 replies
13/22iotests: Drop IMGOPTS use in 267tests/qemu-iotests/267+8 -40 replies
14/22iotests: Avoid qemu-img createtests/qemu-iotests/094 tests/qemu-iotests/111 tests/qemu-iotests/123 +2 more+6 -70 replies
15/22iotests: Use _rm_test_img for deleting test imagestests/qemu-iotests/005 tests/qemu-iotests/019 tests/qemu-iotests/020 +55 more+119 -960 replies
16/22iotests: Avoid cp/mv of test imagestests/qemu-iotests/063 tests/qemu-iotests/063.out tests/qemu-iotests/085 +1 more+13 -190 replies
17/22iotests: Make 091 work with data_filetests/qemu-iotests/091 tests/qemu-iotests/091.out+1 -30 replies
18/22iotests: Make 110 work with data_filetests/qemu-iotests/110 tests/qemu-iotests/110.out+7 -40 replies
19/22iotests: Make 137 work with data_filetests/qemu-iotests/137 tests/qemu-iotests/137.out+13 -80 replies
20/22iotests: Make 198 work with data_filetests/qemu-iotests/198 tests/qemu-iotests/198.out+6 -40 replies
21/22iotests: Disable data_file where it cannot be usedtests/qemu-iotests/007 tests/qemu-iotests/014 tests/qemu-iotests/015 +40 more+124 -531 reply
22/22iotests: Allow check -o data_filetests/qemu-iotests/common.filter tests/qemu-iotests/common.rc+42 -30 replies

Reviews trailers per patch

21 of 22 patches have a Reviewed-by or Acked-by.

PatchMaxim LevitskyEric Blake
1/22R-b R-b
2/22R-b
3/22R-b
4/22R-b
5/22R-b
6/22R-b
7/22R-b
8/22R-b
9/22R-b
10/22R-b
11/22R-b
12/22R-b
13/22R-b
14/22R-b
15/22R-b
16/22R-b
17/22R-b
18/22R-b
19/22R-b
20/22R-b
21/22
22/22R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 00/22] iotests: Allow ./check -o data_file

Hi,

The cover letter from v1 (explaining the motivation behind this series and the general structure) is here:

https://lists.nongnu.org/archive/html/qemu-block/2019-09/msg01323.html

For v2, I’ve addressed more of Maxim’s comments:
- Patch 1: Added; Maxim noted this problem on patch 5, but that patch doesn’t touch all files that have this mistake, so I decided to make it an extra patch

- Patch 20 (now patch 21):
- Added TODO comments where it would make sense to at some point split off some cases into an own test file (so they can run with an external data file, where the whole test now has to be skipped)
- Fixed the reason why we have to skip 138 with external data files
- Disable 261, too (which was added in the meantime)

- Some contextual differences in some patches due to the $SOCK_DIR series

git-backport-diff against v2:

Key:
[----] : patches are identical
[####] : number of functional differences between upstream/downstream patch [down] : patch is downstream-only
The flags [FC] indicate (F)unctional and (C)ontextual differences, respectively

001/22:[down] 'iotests: s/qocw2/qcow2/'
002/22:[----] [--] 'iotests/qcow2.py: Add dump-header-exts' 003/22:[----] [--] 'iotests/qcow2.py: Split feature fields into bits' 004/22:[----] [--] 'iotests: Add _filter_json_filename' 005/22:[----] [--] 'iotests: Filter refcount_order in 036' 006/22:[----] [-C] 'iotests: Replace IMGOPTS by _unsupported_imgopts' 007/22:[----] [--] 'iotests: Drop compat=1.1 in 050' 008/22:[----] [--] 'iotests: Let _make_test_img parse its parameters' 009/22:[----] [--] 'iotests: Add -o and --no-opts to _make_test_img' 010/22:[----] [--] 'iotests: Inject space into -ocompat=0.10 in 051' 011/22:[----] [--] 'iotests: Replace IMGOPTS= by -o' 012/22:[----] [--] 'iotests: Replace IMGOPTS='' by --no-opts' 013/22:[----] [-C] 'iotests: Drop IMGOPTS use in 267' 014/22:[----] [--] 'iotests: Avoid qemu-img create' 015/22:[----] [-C] 'iotests: Use _rm_test_img for deleting test images' 016/22:[----] [--] 'iotests: Avoid cp/mv of test images' 017/22:[----] [--] 'iotests: Make 091 work with data_file' 018/22:[----] [--] 'iotests: Make 110 work with data_file' 019/22:[----] [--] 'iotests: Make 137 work with data_file' 020/22:[----] [--] 'iotests: Make 198 work with data_file' 021/22:[0010] [FC] 'iotests: Disable data_file where it cannot be used' 022/22:[----] [-C] 'iotests: Allow check -o data_file'

Max Reitz (22):
iotests: s/qocw2/qcow2/
iotests/qcow2.py: Add dump-header-exts iotests/qcow2.py: Split feature fields into bits
iotests: Add _filter_json_filename
iotests: Filter refcount_order in 036
iotests: Replace IMGOPTS by _unsupported_imgopts
iotests: Drop compat=1.1 in 050
iotests: Let _make_test_img parse its parameters
iotests: Add -o and --no-opts to _make_test_img
iotests: Inject space into -ocompat=0.10 in 051
iotests: Replace IMGOPTS= by -o
iotests: Replace IMGOPTS='' by --no-opts
iotests: Drop IMGOPTS use in 267
iotests: Avoid qemu-img create
iotests: Use _rm_test_img for deleting test images
iotests: Avoid cp/mv of test images
iotests: Make 091 work with data_file
iotests: Make 110 work with data_file
iotests: Make 137 work with data_file
iotests: Make 198 work with data_file
iotests: Disable data_file where it cannot be used
iotests: Allow check -o data_file

 tests/qemu-iotests/005           |  2 +-
 tests/qemu-iotests/007           |  5 ++-
 tests/qemu-iotests/014           |  2 +
 tests/qemu-iotests/015           |  5 ++-
 tests/qemu-iotests/019           |  6 +--
 tests/qemu-iotests/020           |  6 +--
 tests/qemu-iotests/024           | 10 ++---
 tests/qemu-iotests/026           |  5 ++-
 tests/qemu-iotests/028           |  2 +-
 tests/qemu-iotests/029           |  7 ++--
 tests/qemu-iotests/031           |  9 ++--
 tests/qemu-iotests/031.out       | 36 ++++++++--------
 tests/qemu-iotests/036           | 15 ++++---
 tests/qemu-iotests/036.out       | 66 ++++-------------------------
 tests/qemu-iotests/039           | 27 +++++-------
 tests/qemu-iotests/039.out       | 22 +++++-----
 tests/qemu-iotests/043           |  4 +-
 tests/qemu-iotests/046           |  2 +
 tests/qemu-iotests/048           |  4 +-
 tests/qemu-iotests/050           |  8 +---
 tests/qemu-iotests/051           |  7 ++--
 tests/qemu-iotests/053           |  4 +-
 tests/qemu-iotests/058           |  7 ++--
 tests/qemu-iotests/059           | 20 ++++-----
 tests/qemu-iotests/060           | 14 ++++---
 tests/qemu-iotests/060.out       | 20 ++++-----
 tests/qemu-iotests/061           | 63 +++++++++++++++-------------
 tests/qemu-iotests/061.out       | 72 ++++++++++++++++----------------
 tests/qemu-iotests/062           |  5 ++-
 tests/qemu-iotests/063           | 18 ++++----
 tests/qemu-iotests/063.out       |  3 +-
 tests/qemu-iotests/066           |  7 +++-
 tests/qemu-iotests/067           |  6 ++-
 tests/qemu-iotests/068           |  6 ++-
 tests/qemu-iotests/069           |  2 +-
 tests/qemu-iotests/071           |  7 +++-
 tests/qemu-iotests/073           |  4 ++
 tests/qemu-iotests/074           |  4 +-
 tests/qemu-iotests/079           |  3 +-
 tests/qemu-iotests/080           |  7 ++--
 tests/qemu-iotests/081           |  6 +--
 tests/qemu-iotests/085           | 18 ++++----
 tests/qemu-iotests/085.out       |  8 ++--
 tests/qemu-iotests/088           |  2 +-
 tests/qemu-iotests/090           |  2 +
 tests/qemu-iotests/091           |  2 +-
 tests/qemu-iotests/091.out       |  2 -
 tests/qemu-iotests/092           |  2 +-
 tests/qemu-iotests/094           |  4 +-
 tests/qemu-iotests/095           |  5 ++-
 tests/qemu-iotests/098           |  6 ++-
 tests/qemu-iotests/099           | 10 +++--
 tests/qemu-iotests/103           |  5 ++-
 tests/qemu-iotests/106           |  2 +-
 tests/qemu-iotests/108           | 10 +++--
 tests/qemu-iotests/109           |  4 +-
 tests/qemu-iotests/110           | 11 +++--
 tests/qemu-iotests/110.out       |  4 +-
 tests/qemu-iotests/111           |  3 +-
 tests/qemu-iotests/112           | 37 ++++++++--------
 tests/qemu-iotests/114           |  2 +
 tests/qemu-iotests/115           |  3 +-
 tests/qemu-iotests/121           |  9 ++--
 tests/qemu-iotests/122           |  6 ++-
 tests/qemu-iotests/123           |  4 +-
 tests/qemu-iotests/125           |  2 +-
 tests/qemu-iotests/137           | 17 +++++---
 tests/qemu-iotests/137.out       |  6 +--
 tests/qemu-iotests/138           |  8 ++--
 tests/qemu-iotests/141           |  4 +-
 tests/qemu-iotests/142           |  2 +-
 tests/qemu-iotests/144           |  4 +-
 tests/qemu-iotests/153           | 12 ++----
 tests/qemu-iotests/156           | 10 ++++-
 tests/qemu-iotests/159           |  2 +-
 tests/qemu-iotests/160           |  3 +-
 tests/qemu-iotests/161           |  4 +-
 tests/qemu-iotests/170           |  2 +-
 tests/qemu-iotests/172           |  6 +--
 tests/qemu-iotests/173           |  3 +-
 tests/qemu-iotests/174           |  2 +-
 tests/qemu-iotests/175           |  2 +-
 tests/qemu-iotests/176           |  7 +++-
 tests/qemu-iotests/178           |  6 +--
 tests/qemu-iotests/182           |  2 +-
 tests/qemu-iotests/183           |  2 +-
 tests/qemu-iotests/185           |  4 +-
 tests/qemu-iotests/187           |  6 +--
 tests/qemu-iotests/190           |  4 +-
 tests/qemu-iotests/191           | 11 ++---
 tests/qemu-iotests/195           |  2 +-
 tests/qemu-iotests/197           |  6 +--
 tests/qemu-iotests/198           |  6 ++-
 tests/qemu-iotests/198.out       |  4 +-
 tests/qemu-iotests/200           |  7 ++--
 tests/qemu-iotests/201           |  6 +--
 tests/qemu-iotests/214           |  3 +-
 tests/qemu-iotests/215           |  6 +--
 tests/qemu-iotests/217           |  3 +-
 tests/qemu-iotests/220           |  5 ++-
 tests/qemu-iotests/225           |  2 +-
 tests/qemu-iotests/229           |  3 +-
 tests/qemu-iotests/232           |  4 +-
 tests/qemu-iotests/243           | 10 +++--
 tests/qemu-iotests/244           | 15 ++++---
 tests/qemu-iotests/247           |  4 +-
 tests/qemu-iotests/249           |  4 +-
 tests/qemu-iotests/250           |  5 ++-
 tests/qemu-iotests/252           |  2 +-
 tests/qemu-iotests/261           |  5 ++-
 tests/qemu-iotests/265           |  2 +-
 tests/qemu-iotests/267           | 17 +++++---
 tests/qemu-iotests/common.filter | 47 ++++++++++++++++++++-
 tests/qemu-iotests/common.rc     | 63 ++++++++++++++++++++++++----
 tests/qemu-iotests/qcow2.py      | 23 ++++++++--
 115 files changed, 614 insertions(+), 460 deletions(-)
Signature · 1 line
2.23.0