media: vpe: maintenance
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v3 Latest21 patches 0 repliesNew
- v221 patches 4 repliesSuperseded
- v116 patches 7 repliesSuperseded
Changes in v3 from the cover letter
- Fix a type causing a compile error
- Address Hans' comment on the v4l2_common patches
- Rework patch 16 a bit to limit the expanded use of fmt.pix_mp and use a local pointer whenever possible.
- Reworked csc_set_coeff() to use the updated format_info helper and also to properly handle the v4l2_format type passed as arguments
Patches in v3 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/21 | media: ti-vpe: Fix a parallel build issuedrivers/ | +1 | 0 replies | |
| 2/21 | media: ti-vpe: vpe: Fix Motion Vector vpdma stridedrivers/ | +13 | 0 replies | |
| 3/21 | media: ti-vpe: vpe: Add missing null pointer checksdrivers/ | +12 | 0 replies | |
| 4/21 | media: ti-vpe: vpe: Remove unnecessary use of container_ofdrivers/ | +7 | 0 replies | |
| 5/21 | media: ti-vpe: Add support for SEQ_BTdrivers/ | +46 | 0 replies | |
| 6/21 | media: ti-vpe: Add support for NV21 formatdrivers/ drivers/ drivers/ +1 more | +34 | 0 replies | |
| 7/21 | media: ti-vpe: Set MAX height supported to 2048 pixelsdrivers/ | +1 | 0 replies | |
| 8/21 | media: ti-vpe: vpe: fix a v4l2-compliance failure causing a kernel panicdrivers/ | +1 | 0 replies | |
| 9/21 | media: ti-vpe: vpe: fix a v4l2-compliance warning about invalid pixel formatdrivers/ | +9 | 0 replies | |
| 10/21 | media: ti-vpe: vpe: Make sure YUYV is set as default formatdrivers/ | +1 | 0 replies | |
| 11/21 | media: ti-vpe: vpe: fix a v4l2-compliance failure about invalid sizeimagedrivers/ drivers/ | +5 | 0 replies | |
| 12/21 | media: ti-vpe: vpe: fix a v4l2-compliance failure about frame sequence numberdrivers/ | +1 | 0 replies | |
| 13/21 | media: ti-vpe: vpe: ensure buffers are cleaned up properly in abort casesdrivers/ | +9 | 0 replies | |
| 14/21 | media: ti-vpe: vpdma: Use fixed type for address in descriptordrivers/ | +2 | 0 replies | |
| 15/21 | media: ti-vpe: Set the DMA mask and coherent maskdrivers/ | +7 | 0 replies | |
| 16/21 | media: ti-vpe: vpe: use standard struct instead of duplicating fieldsdrivers/ | +101 | 0 replies | |
| 17/21 | media: ti-vpe: vpe: fix v4l2_compliance issue related to xfer_funcdrivers/ | +4 | 0 replies | |
| 18/21 | media: ti-vpe: csc: rgb-to-yuv HD full range coeff are wrongdrivers/ | +2 | 0 replies | |
| 19/21 | media: v4l2-common: add pixel encoding supportdrivers/ include/ | +95 | 0 replies | |
| 20/21 | media: v4l2-common: add RGB565 and RGB55 to v4l2_format_infodrivers/ | +2 | 0 replies | |
| 21/21 | media: ti-vpe: vpe: don't rely on colorspace member for conversiondrivers/ drivers/ drivers/ | +184 | 0 replies |
Reviews trailers per patch
8 of 21 patches have a Reviewed-by or Acked-by.
| Patch | Nikhil Devshatwar | Tomi Valkeinen |
|---|---|---|
| 1/21 | ||
| 2/21 | A-b | |
| 3/21 | ||
| 4/21 | ||
| 5/21 | ||
| 6/21 | R-b | |
| 7/21 | ||
| 8/21 | R-b | |
| 9/21 | R-b | |
| 10/21 | R-b | |
| 11/21 | R-b | |
| 12/21 | R-b | |
| 13/21 | R-b | |
| 14/21 | ||
| 15/21 | ||
| 16/21 | ||
| 17/21 | ||
| 18/21 | ||
| 19/21 | ||
| 20/21 | ||
| 21/21 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [Patch v3 00/21] media: vpe: maintenance
This a collection of backlog patches I have been carrying for the VPE driver.
It adds supports for SEQ_BT as well as NV21.
And fixes a number of issues both through v4l2-compliance and normal usage.
Changes since v2:
- Fix a type causing a compile error
- Address Hans' comment on the v4l2_common patches
- Rework patch 16 a bit to limit the expanded use of fmt.pix_mp and use a local pointer whenever possible.
- Reworked csc_set_coeff() to use the updated format_info helper and also to properly handle the v4l2_format type passed as arguments
Changes since v1:
- Added a missing from my first set fixing a Makefile issue
- Added a csc table fix to match the technical specification
- Base on Hans' comment I reworked the last two patches which yielded one more patch
- This also led me to create additional patches to the v4l2_format_info table to simplify pixel encoding lookup
======================================
v4l2-compliance SHA: 5b168dc8473911227890526bad26553d9e8ff81b, 32 bits
Compliance test for vpe device /dev/video0:
Driver Info:
Driver name : vpe Card type : vpe Bus info : platform:vpe Driver version : 5.4.0 Capabilities : 0x84204000
Video Memory-to-Memory Multiplanar Streaming
Extended Pix Format
Device Capabilities
Device Caps : 0x04204000
Video Memory-to-Memory Multiplanar Streaming
Extended Pix Format
Required ioctls:
test VIDIOC_QUERYCAP: OK
Allow for multiple opens:
test second /dev/video0 open: OK
test VIDIOC_QUERYCAP: OK
test VIDIOC_G/S_PRIORITY: OK
test for unlimited opens: OK
Debug ioctls:
test VIDIOC_DBG_G/S_REGISTER: OK (Not Supported) test VIDIOC_LOG_STATUS: OK (Not Supported)
Input ioctls:
test VIDIOC_G/S_TUNER/ENUM_FREQ_BANDS: OK (Not Supported) test VIDIOC_G/S_FREQUENCY: OK (Not Supported) test VIDIOC_S_HW_FREQ_SEEK: OK (Not Supported) test VIDIOC_ENUMAUDIO: OK (Not Supported)
test VIDIOC_G/S/ENUMINPUT: OK (Not Supported) test VIDIOC_G/S_AUDIO: OK (Not Supported)
Inputs: 0 Audio Inputs: 0 Tuners: 0
Output ioctls:
test VIDIOC_G/S_MODULATOR: OK (Not Supported) test VIDIOC_G/S_FREQUENCY: OK (Not Supported) test VIDIOC_ENUMAUDOUT: OK (Not Supported) test VIDIOC_G/S/ENUMOUTPUT: OK (Not Supported) test VIDIOC_G/S_AUDOUT: OK (Not Supported)
Outputs: 0 Audio Outputs: 0 Modulators: 0
Input/Output configuration ioctls:
test VIDIOC_ENUM/G/S/QUERY_STD: OK (Not Supported) test VIDIOC_ENUM/G/S/QUERY_DV_TIMINGS: OK (Not Supported) test VIDIOC_DV_TIMINGS_CAP: OK (Not Supported) test VIDIOC_G/S_EDID: OK (Not Supported)
Control ioctls:
test VIDIOC_QUERY_EXT_CTRL/QUERYMENU: OK test VIDIOC_QUERYCTRL: OK
test VIDIOC_G/S_CTRL: OK
test VIDIOC_G/S/TRY_EXT_CTRLS: OK test VIDIOC_(UN)SUBSCRIBE_EVENT/DQEVENT: OK test VIDIOC_G/S_JPEGCOMP: OK (Not Supported) Standard Controls: 1 Private Controls: 1
Format ioctls:
test VIDIOC_ENUM_FMT/FRAMESIZES/FRAMEINTERVALS: OK test VIDIOC_G/S_PARM: OK (Not Supported) test VIDIOC_G_FBUF: OK (Not Supported) test VIDIOC_G_FMT: OK
test VIDIOC_TRY_FMT: OK
test VIDIOC_S_FMT: OK
test VIDIOC_G_SLICED_VBI_CAP: OK (Not Supported) test Cropping: OK
test Composing: OK
test Scaling: OK
Codec ioctls:
test VIDIOC_(TRY_)ENCODER_CMD: OK (Not Supported) test VIDIOC_G_ENC_INDEX: OK (Not Supported) test VIDIOC_(TRY_)DECODER_CMD: OK (Not Supported)
Buffer ioctls:
warn: v4l2-test-buffers.cpp(683): VIDIOC_CREATE_BUFS not supported
warn: v4l2-test-buffers.cpp(683): VIDIOC_CREATE_BUFS not supported
test VIDIOC_REQBUFS/CREATE_BUFS/QUERYBUF: OK
test VIDIOC_EXPBUF: OK
test Requests: OK (Not Supported)
Test input 0:
Streaming ioctls:
test read/write: OK (Not Supported)
test blocking wait: OK
Video Capture Multiplanar: Captured 58 buffers test MMAP (no poll): OK
Video Capture Multiplanar: Captured 58 buffers test MMAP (select): OK
Video Capture Multiplanar: Captured 58 buffers test MMAP (epoll): OK
test USERPTR (no poll): OK (Not Supported) test USERPTR (select): OK (Not Supported) test DMABUF: Cannot test, specify --expbuf-device
Total for vpe device /dev/video0: 51, Succeeded: 51, Failed: 0, Warnings: 2
======================================
Benoit Parrot (18):
media: ti-vpe: Fix a parallel build issue
media: ti-vpe: vpe: Fix Motion Vector vpdma stride
media: ti-vpe: vpe: Add missing null pointer checks
media: ti-vpe: vpe: Remove unnecessary use of container_of
media: ti-vpe: vpe: fix a v4l2-compliance failure causing a kernel
panic
media: ti-vpe: vpe: fix a v4l2-compliance warning about invalid pixel
format
media: ti-vpe: vpe: Make sure YUYV is set as default format
media: ti-vpe: vpe: fix a v4l2-compliance failure about invalid
sizeimage
media: ti-vpe: vpe: fix a v4l2-compliance failure about frame sequence
number
media: ti-vpe: vpe: ensure buffers are cleaned up properly in abort
cases
media: ti-vpe: vpdma: Use fixed type for address in descriptor
media: ti-vpe: Set the DMA mask and coherent mask
media: ti-vpe: vpe: use standard struct instead of duplicating fields
media: ti-vpe: vpe: fix v4l2_compliance issue related to xfer_func
media: ti-vpe: csc: rgb-to-yuv HD full range coeff are wrong
media: v4l2-common: add pixel encoding support
media: v4l2-common: add RGB565 and RGB55 to v4l2_format_info
media: ti-vpe: vpe: don't rely on colorspace member for conversion
Nikhil Devshatwar (2):
media: ti-vpe: Add support for SEQ_BT
media: ti-vpe: Add support for NV21 format
Ram Prasad (1):
media: ti-vpe: Set MAX height supported to 2048 pixels
drivers/media/platform/Makefile | 4 +- drivers/media/platform/ti-vpe/csc.c | 254 ++++++++----- drivers/media/platform/ti-vpe/csc.h | 4 +- drivers/media/platform/ti-vpe/vpdma.c | 11 +- drivers/media/platform/ti-vpe/vpdma.h | 2 + drivers/media/platform/ti-vpe/vpdma_priv.h | 5 +- drivers/media/platform/ti-vpe/vpe.c | 394 ++++++++++++--------- drivers/media/v4l2-core/v4l2-common.c | 128 +++---- include/media/v4l2-common.h | 33 +- 9 files changed, 520 insertions(+), 315 deletions(-)
Signature · 1 line
2.17.1