Skip to content

Last-minute fixes to auth-token-hmac patch series

David Sommerseth openvpn-devel 1 version In review

Get series with b4
b4 am [email protected]...

Versions newest first

  1. v1 Latest3 patches 3 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3auth-token: Fix building with --disable-serversrc/openvpn/push.c src/openvpn/ssl_common.h+3 -11 reply
2/3auth-token: Fix compiler complaints with --disable-managementsrc/openvpn/ssl.h+2 -21 reply
3/3Improve the comments related to auth-token-hmac patchessrc/openvpn/auth_token.h src/openvpn/ssl_common.h+1 -31 reply

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchGert Doering
1/3A-b
2/3A-b
3/3A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [Openvpn-devel] [PATCH 0/3] Last-minute fixes to auth-token-hmac patch series

During the review of the auth-token-hmac patches from Arne Schwabe, there were still a few minor issues left out. To avoid holding back further inclusion, we decided to add these patches on top of the patches from Arne.

The first patch, --disable-server fix, is only needed when running ./configure with --disable-server. Otherwise the existing patches works fine.

The second patch, --disable-management fix, just fixes a long outstanding compiler warning.

And the final patch with comment updates are just clarifications and minor improvements.

David Sommerseth (3):
auth-token: Fix building with --disable-server
auth-token: Fix compiler complaints with --disable-management Improve the comments related to auth-token-hmac patches

 src/openvpn/auth_token.h | 2 --
 src/openvpn/push.c       | 2 ++
 src/openvpn/ssl.h        | 4 ++--
 src/openvpn/ssl_common.h | 4 ++--
 4 files changed, 6 insertions(+), 6 deletions(-)
Signature · 4 lines
kind regards,

David Sommerseth
OpenVPN Inc