Skip to content

mbuf: copy/cloning enhancements

Stephen Hemminger dpdk-dev 6 versions – Applied

Status from this message: Applied, thanks.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest5 patches 5 repliesApplied
  2. v55 patches 6 repliesSuperseded
  3. v44 patches 0 repliesSuperseded
Earlier versions · 3
VersionPostedPatchesRepliesStatus
v36 patches5 repliesSuperseded
v26 patches0 repliesSuperseded
v15 patches3 repliesSuperseded

Patches in v6 Applied

#Subject and filesSizeRepliesApplied
1/5mbuf: don't generate invalid mbuf in clone testapp/test/test_mbuf.c+3 -01 reply
2/5mbuf: delinline rte_pktmbuf_linearizelib/librte_mbuf/rte_mbuf.c lib/librte_mbuf/rte_mbuf.h lib/librte_mbuf/rte_mbuf_version.map+49 -321 reply
3/5mbuf: deinline rte_pktmbuf_clonelib/librte_mbuf/rte_mbuf.c lib/librte_mbuf/rte_mbuf.h lib/librte_mbuf/rte_mbuf_version.map+42 -361 reply
4/5mbuf: add a pktmbuf copy routinelib/librte_mbuf/rte_mbuf.c lib/librte_mbuf/rte_mbuf.h lib/librte_mbuf/rte_mbuf_version.map+122 -112 replies
5/5mbuf: add pktmbuf copy testapp/test/test_mbuf.c+157 -00 replies

Reviews trailers per patch

All 5 patches have a Reviewed-by or Acked-by.

PatchOlivier MatzAndrew Rybchenko
1/5A-b
2/5A-b A-b
3/5A-b A-b
4/5A-b
5/5A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v6 thread

Cover letter [dpdk-dev] [PATCH v6 0/5] mbuf: copy/cloning enhancements

This patch set is all about improving the mbuf related cloning and copying. They are motivated by seeing issues with mbuf copying in rte_pdump and realized this a wider and more general problem. The pdump copy could not handle different size pools and did not handle meta data, etc.

They cause no functional or ABI changes. The only visible part to older code is converting a couple of inlines to real functions. This kind of change confuses checkpatch which thinks these new functions should be marked experimental when they must not be.

v6 - incorporate feedback from Oliver for pktmbuf_copy
add more comments and tests for pktmbuf_copy

v5 - add back the test (dropped by accident in v4) v4 - common mbuf header fields copy routine v3 - split linearize into internal/external
copy private data in pktmbuf_copy
v2 - add pdump use of pktmbuf_copy
fix version in map

Stephen Hemminger (5):
mbuf: don't generate invalid mbuf in clone test
mbuf: delinline rte_pktmbuf_linearize
mbuf: deinline rte_pktmbuf_clone
mbuf: add a pktmbuf copy routine
mbuf: add pktmbuf copy test

 app/test/test_mbuf.c                 | 160 +++++++++++++++++++++++++++
 lib/librte_mbuf/rte_mbuf.c           | 153 +++++++++++++++++++++++++
 lib/librte_mbuf/rte_mbuf.h           | 129 +++++++++------------
 lib/librte_mbuf/rte_mbuf_version.map |   8 ++
 4 files changed, 372 insertions(+), 78 deletions(-)
Signature · 1 line
2.20.1