Skip to content

Better NBD string length handling

Eric Blake qemu-devel 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest4 patches 14 repliesIn review
  2. v22 patches 7 repliesSuperseded
  3. v11 patch 2 repliesSuperseded

Changes in v3 from the cover letter

- Patch 1, 2: new [Vladimir]
- Patch 3: improve error messages and fix a memleak [Vladimir]
- Patch 3: bump name length from 256 to 4k (R-b dropped)
- Patch 4: add R-b, but tweak to defer to 5.0

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4nbd/server: Prefer heap over stack for parsing client namesinclude/block/nbd.h nbd/server.c+20 -155 replies
2/4bitmap: Enforce maximum bitmap name lengthblock/dirty-bitmap.c block/qcow2-bitmap.c include/block/dirty-bitmap.h +1 more+14 -45 replies
3/4nbd: Don't send oversize stringsblock/nbd.c blockdev-nbd.c include/block/nbd.h +3 more+58 -123 replies
4/4nbd: Allow description when creating NBD blockdevblockdev-nbd.c monitor/hmp-cmds.c qapi/block.json +2 more+18 -70 replies

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchMaxim LevitskyVladimir Sementsov-Ogievskiy
1/4R-b R-b
2/4R-b R-b
3/4R-b R-b
4/4R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 for-4.2 0/4] Better NBD string length handling

This series was originally posted before soft freeze, but then KVM Forum interfered. I think that patches 1-3 are bug fixes still appropriate for -rc2 if they get good reviews, but patch 4 is a new feature and now only appropriate for 5.0.

Since v2:
- Patch 1, 2: new [Vladimir]
- Patch 3: improve error messages and fix a memleak [Vladimir]
- Patch 3: bump name length from 256 to 4k (R-b dropped)
- Patch 4: add R-b, but tweak to defer to 5.0

Eric Blake (4):
nbd/server: Prefer heap over stack for parsing client names
bitmap: Enforce maximum bitmap name length
nbd: Don't send oversize strings
nbd: Allow description when creating NBD blockdev

 qapi/block-core.json         |  2 +-
 qapi/block.json              |  9 +++++---
 include/block/dirty-bitmap.h |  2 ++
 include/block/nbd.h          | 12 +++++-----
 block/dirty-bitmap.c         | 12 +++++++---
 block/nbd.c                  | 10 +++++++++
 block/qcow2-bitmap.c         |  2 ++
 blockdev-nbd.c               | 14 +++++++++++-
 monitor/hmp-cmds.c           |  4 ++--
 nbd/client.c                 | 18 ++++++++++++---
 nbd/server.c                 | 43 ++++++++++++++++++++++++------------
 qemu-nbd.c                   |  9 ++++++++
 tests/qemu-iotests/223       |  2 +-
 tests/qemu-iotests/223.out   |  1 +
 14 files changed, 106 insertions(+), 34 deletions(-)
Signature · 1 line
2.21.0