Skip to content

Implement UNIT_CELL_SIZE control

Ricardo Ribalda Delgado linux-media lkml 5 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v12 Latest8 patches 0 repliesNew
  2. v108 patches 3 repliesSuperseded
  3. v98 patches 5 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v88 patches3 repliesSuperseded
v78 patches0 repliesSuperseded

Patches in v12 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8media: v4l2-core: Implement v4l2_ctrl_new_std_compounddrivers/media/v4l2-core/v4l2-ctrls.c include/media/v4l2-ctrls.h+64 -70 replies
2/8Documentation: v4l2_ctrl_new_std_compoundDocumentation/media/kapi/v4l2-controls.rst+9 -00 replies
3/8media: add V4L2_CTRL_TYPE_AREA control typedrivers/media/v4l2-core/v4l2-ctrls.c include/media/v4l2-ctrls.h include/uapi/linux/videodev2.h+69 -00 replies
4/8Documentation: media: Document V4L2_CTRL_TYPE_AREADocumentation/media/uapi/v4l/vidioc-queryctrl.rst Documentation/media/videodev2.h.rst.exceptions+7 -00 replies
5/8media: add V4L2_CID_UNIT_CELL_SIZE controldrivers/media/v4l2-core/v4l2-ctrls.c include/uapi/linux/v4l2-controls.h+6 -00 replies
6/8Documentation: media: Describe V4L2_CID_UNIT_CELL_SIZEDocumentation/media/uapi/v4l/ext-ctrls-image-source.rst+10 -00 replies
7/8media: v4l2-ctrl: Add new helper v4l2_ctrl_ptr_createinclude/media/v4l2-ctrls.h+12 -00 replies
8/8media: imx214: Add new control with V4L2_CID_UNIT_CELL_SIZEdrivers/media/i2c/imx214.c+9 -00 replies

Reviews trailers per patch

5 of 8 patches have a Reviewed-by or Acked-by.

PatchJacopo MondiPhilipp Zabel
1/8
2/8R-b
3/8R-b
4/8R-b R-b
5/8R-b
6/8R-b
7/8
8/8

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v12 thread

Cover letter [PATCH v12 0/8] Implement UNIT_CELL_SIZE control

UNIT_CELL_SIZE is a control that represents the size of a cell (pixel). We required a bit of boilerplate to add this control :)
- New way to init compount controls
- New control type

Thanks to Hans, Jacopo and Philipp for your help.

You might want to see the series at my github repository if needed.

https://github.com/ribalda/linux/tree/unit-size-v10

v12: Fix htmldocs warnings (Thanks Hans!)

v11: Fix documentation related to binning

v10: Typos in documentation and minor color style

v9: Rename helper to v4l2_ctrl_ptr_create

v8: Fix my email on some patches (sorry for the mess)

v7: Add new helper v4l2_ctrl_ptr_from_void

v4, v5 of this patchset never reached the mailing list.

Ricardo Ribalda Delgado (8):
media: v4l2-core: Implement v4l2_ctrl_new_std_compound
Documentation: v4l2_ctrl_new_std_compound
media: add V4L2_CTRL_TYPE_AREA control type
Documentation: media: Document V4L2_CTRL_TYPE_AREA
media: add V4L2_CID_UNIT_CELL_SIZE control
Documentation: media: Describe V4L2_CID_UNIT_CELL_SIZE
media: v4l2-ctrl: Add new helper v4l2_ctrl_ptr_create
media: imx214: Add new control with V4L2_CID_UNIT_CELL_SIZE

 Documentation/media/kapi/v4l2-controls.rst    |  9 +++
 .../media/uapi/v4l/ext-ctrls-image-source.rst | 10 +++
 .../media/uapi/v4l/vidioc-queryctrl.rst       |  6 ++
 .../media/videodev2.h.rst.exceptions          |  1 +
 drivers/media/i2c/imx214.c                    |  9 +++
 drivers/media/v4l2-core/v4l2-ctrls.c          | 76 +++++++++++++++++--
 include/media/v4l2-ctrls.h                    | 75 ++++++++++++++++++
 include/uapi/linux/v4l2-controls.h            |  1 +
 include/uapi/linux/videodev2.h                |  6 ++
 9 files changed, 186 insertions(+), 7 deletions(-)
Signature · 1 line
2.23.0