Skip to content

RFC: implement reopen for nbd driver

Maxim Levitsky qemu-devel 1 version Applied

Status from this message: Thanks, applied to my block branch:

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest1 patch 1 replyApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/1nbd: add empty .bdrv_reopen_prepareblock/nbd.c+15 -01 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/1] RFC: implement reopen for nbd driver

Hi,
It looks like nbd driver doesn't have support for reopen, which doesn't allow to commit qcow2 snapshots which have nbd export as a base file.
This is because the base is opened read-only, and only when commit job starts it reopens the base read-write.

Now after talking with Eric Blake, I understood that nbd doesn't have the ability to tell the server to open read/only and then change this on the fly, thus even when opening an export as read-only the server will still allow writes.

This means that an empty .bdrv_reopen_prepare
(well except checking that export is not read-only) is supposed to be enough.

Sending this as RFC, since I am not sure that this is the correct solution.

Best regards,
Maxim Levitsky

Maxim Levitsky (1):
nbd: add empty .bdrv_reopen_prepare

 block/nbd.c | 15 +++++++++++++++
 1 file changed, 15 insertions(+)
Signature · 1 line
2.17.2