usb: typec: Small API improvement
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v4 Latest9 patches 1 replyIn review
- v39 patches 7 repliesSuperseded
- v27 patches 5 repliesSuperseded
Earlier versions · 1
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v1 | 7 patches | 18 replies | Superseded |
Patches in v4 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/9 | usb: typec: Copy everything from struct typec_capability during registrationdrivers/ | +14 | 1 reply | |
| 2/9 | usb: typec: Introduce typec_get_drvdata()drivers/ include/ | +15 | 0 replies | |
| 3/9 | usb: typec: Separate the operations vectordrivers/ include/ | +49 | 0 replies | |
| 4/9 | usb: typec: tcpm: Start using struct typec_operationsdrivers/ | +20 | 0 replies | |
| 5/9 | usb: typec: tps6598x: Start using struct typec_operationsdrivers/ | +26 | 0 replies | |
| 6/9 | usb: typec: ucsi: Start using struct typec_operationsdrivers/ | +11 | 0 replies | |
| 7/9 | usb: typec: hd3ss3220: Start using struct typec_operationsdrivers/ | +13 | 0 replies | |
| 8/9 | usb: typec: Remove the callback members from struct typec_capabilitydrivers/ include/ | +11 | 0 replies | |
| 9/9 | usb: typec: Remove unused members from struct typec_capabilityinclude/ | +0 | 0 replies |
Reviews trailers per patch
All 9 patches have a Reviewed-by or Acked-by.
| Patch | Guenter Roeck |
|---|---|
| 1/9 | R-b |
| 2/9 | R-b |
| 3/9 | R-b |
| 4/9 | R-b |
| 5/9 | R-b |
| 6/9 | R-b |
| 7/9 | R-b |
| 8/9 | R-b |
| 9/9 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v4 0/9] usb: typec: Small API improvement
Hi,
I'm sending one more version of these patches to you before sending them to Greg. There are still some fixes coming that will conflict with patches in this series. Since I'm not in any hurry with these, I'll wait for those fixes in this case.
The only change in this version is that I'm now checking that kmemdup did not fail in the first patch.
Cover letter from v3:
The broken conditions in the *_store() functions should now be fixed.
Cover letter from v2:
In this version there should be no more semantic changes.
The original cover letter:
This series moves the callback members from struct typec_capabilities to a new struct typec_operations. That removes the need for the drivers to keep a copy of the struct typec_capabilites if they don't need it, and struct typec_operations can probable always be constified.
The change is small, however I think the code ends up being a bit more cleaner looking this way. Let me know if it's OK.
thanks,
Heikki Krogerus (9):
usb: typec: Copy everything from struct typec_capability during
registration
usb: typec: Introduce typec_get_drvdata()
usb: typec: Separate the operations vector
usb: typec: tcpm: Start using struct typec_operations
usb: typec: tps6598x: Start using struct typec_operations
usb: typec: ucsi: Start using struct typec_operations
usb: typec: hd3ss3220: Start using struct typec_operations
usb: typec: Remove the callback members from struct typec_capability
usb: typec: Remove unused members from struct typec_capability
drivers/usb/typec/class.c | 42 ++++++++++++++++++++++-------- drivers/usb/typec/hd3ss3220.c | 24 +++++++++-------- drivers/usb/typec/tcpm/tcpm.c | 45 ++++++++++++++------------------ drivers/usb/typec/tps6598x.c | 49 +++++++++++++++++++---------------- drivers/usb/typec/ucsi/ucsi.c | 22 ++++++++-------- include/linux/usb/typec.h | 41 ++++++++++++++++------------- 6 files changed, 124 insertions(+), 99 deletions(-)
Signature · 1 line
2.23.0