Skip to content

RFC thunderbolt: Add support for USB4

Mika Westerberg linux-usb lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest22 patches 72 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/22thunderbolt: Introduce tb_switch_is_icm()drivers/thunderbolt/lc.c drivers/thunderbolt/switch.c drivers/thunderbolt/tb.h+18 -46 replies
2/22thunderbolt: Log switch route string on config read/write timeoutdrivers/thunderbolt/ctl.c+4 -40 replies
3/22thunderbolt: Log warning if adding switch failsdrivers/thunderbolt/tb.c+4 -12 replies
4/22thunderbolt: Make tb_sw_write() take const parameterdrivers/thunderbolt/tb.h+1 -10 replies
5/22thunderbolt: Add helper macros to iterate over switch portsdrivers/thunderbolt/icm.c drivers/thunderbolt/switch.c drivers/thunderbolt/tb.c +2 more+57 -273 replies
6/22thunderbolt: Add support for lane bondingDocumentation/ABI/testing/sysfs-bus-thunderbolt drivers/thunderbolt/icm.c drivers/thunderbolt/lc.c +7 more+429 -106 replies
7/22thunderbolt: Add default linking between ports if not provided by DROMdrivers/thunderbolt/eeprom.c drivers/thunderbolt/switch.c+32 -112 replies
8/22thunderbolt: Add downstream PCIe port mappings for Alpine and Titan Ridgedrivers/thunderbolt/tb.c drivers/thunderbolt/tb.h+28 -12 replies
9/22thunderbolt: Convert basic adapter register names to follow the USB4 specdrivers/thunderbolt/switch.c drivers/thunderbolt/tb_regs.h drivers/thunderbolt/tunnel.c+22 -212 replies
10/22thunderbolt: Convert PCIe adapter register names to use USB4 namesdrivers/thunderbolt/switch.c drivers/thunderbolt/tb_regs.h+8 -61 reply
11/22thunderbolt: Convert DP adapter register names to follow the USB4 specdrivers/thunderbolt/switch.c drivers/thunderbolt/tb_regs.h drivers/thunderbolt/tunnel.c+46 -441 reply
12/22thunderbolt: Add Display Port CM handshake for Titan Ridge devicesdrivers/thunderbolt/tb_regs.h drivers/thunderbolt/tunnel.c+47 -02 replies
13/22thunderbolt: Add Display Port adapter pairing and resource managementdrivers/thunderbolt/lc.c drivers/thunderbolt/switch.c drivers/thunderbolt/tb.c +2 more+389 -340 replies
14/22thunderbolt: Add bandwidth management for Display Port tunnelsdrivers/thunderbolt/path.c drivers/thunderbolt/tb.c drivers/thunderbolt/tb.h +3 more+371 -40 replies
15/22thunderbolt: Make tb_find_port() available to other filesdrivers/thunderbolt/switch.c drivers/thunderbolt/tb.c drivers/thunderbolt/tb.h+22 -200 replies
16/22thunderbolt: Call tb_eeprom_get_drom_offset() from tb_eeprom_read_n()drivers/thunderbolt/eeprom.c+43 -450 replies
17/22thunderbolt: Add initial support for USB4drivers/thunderbolt/Kconfig drivers/thunderbolt/Makefile drivers/thunderbolt/eeprom.c +9 more+1162 -12133 replies
18/22thunderbolt: Make tb_switch_find_cap() available to other filesdrivers/thunderbolt/cap.c drivers/thunderbolt/tb.h+11 -10 replies
19/22thunderbolt: Add support for Time Management Unitdrivers/thunderbolt/Makefile drivers/thunderbolt/switch.c drivers/thunderbolt/tb.c +3 more+481 -12 replies
20/22thunderbolt: Add support for USB tunnelsdrivers/thunderbolt/switch.c drivers/thunderbolt/tb.c drivers/thunderbolt/tb.h +4 more+393 -272 replies
21/22thunderbolt: Update documentation with the USB4 informationDocumentation/admin-guide/thunderbolt.rst+22 -52 replies
22/22thunderbolt: Do not start firmware unless asked by the userdrivers/thunderbolt/icm.c drivers/thunderbolt/tb.c+11 -74 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [RFC PATCH 00/22] thunderbolt: Add support for USB4

Hi all,

I'm sending this as RFC because the series is still missing important features such as power management so not ready for merging. However, I think it is good to get any early feedback from the community. We are working to add support for the missing features.

USB4 is the public specification of Thunderbolt 3 protocol and can be downloaded here:

https://www.usb.org/sites/default/files/USB4%20Specification_1.zip

USB4 is about tunneling different protocols over a single cable (in the same way as Thunderbolt). The current USB4 spec supports PCIe, Display Port and USB 3.x, and also software based protocols such as networking between domains (hosts).

So far PCs have been using firmware based Connection Manager and Apple systems have been using software based one. A Connection Manager is the entity that handles creation of different tunnel types through the USB4 (and Thunderbolt) fabric. With USB4 the plan is to have software based Connection Manager everywhere but some early systems will also support firmware to allow OS downgrade for example.

Current Linux Thunderbolt driver supports both "modes" and can detect which one to use dynamically.

This series first adds support for Thunderbolt 3 devices to the software connection manager and then extends that to support USB4 compliant hosts and devices (this applies to both firmware and software based connection managers). With this series the following features are supported also for USB4 compliant devices:

- PCIe tunneling
- Display Port tunneling
- USB 3.x tunneling
- P2P networking (implemented in drivers/net/thunderbolt.c)
- Host and device NVM firmware upgrade

We also add two new sysfs attributes under each device that expose link speed and width to userspace. The rest of the userspace ABI stays the same.

I'm including Linux USB folks as well because USB4 is officially coming from USB-IF which puts us on same boat now.

While I changed the user visible Kconfig string to mention "USB4" (the Kconfig option is still CONFIG_THUNDERBOLT), I'm wondering whether we should move the whole Thunderbolt driver under drivers/usb/thunderbolt as well?

Mika Westerberg (19):
thunderbolt: Introduce tb_switch_is_icm()
thunderbolt: Log switch route string on config read/write timeout
thunderbolt: Log warning if adding switch fails
thunderbolt: Make tb_sw_write() take const parameter
thunderbolt: Add helper macros to iterate over switch ports
thunderbolt: Add support for lane bonding
thunderbolt: Add default linking between ports if not provided by DROM
thunderbolt: Add downstream PCIe port mappings for Alpine and Titan Ridge
thunderbolt: Convert basic adapter register names to follow the USB4 spec
thunderbolt: Convert PCIe adapter register names to use USB4 names
thunderbolt: Convert DP adapter register names to follow the USB4 spec
thunderbolt: Add Display Port CM handshake for Titan Ridge devices
thunderbolt: Add Display Port adapter pairing and resource management
thunderbolt: Add bandwidth management for Display Port tunnels
thunderbolt: Make tb_find_port() available to other files
thunderbolt: Call tb_eeprom_get_drom_offset() from tb_eeprom_read_n()
thunderbolt: Add initial support for USB4
thunderbolt: Update documentation with the USB4 information
thunderbolt: Do not start firmware unless asked by the user

Rajmohan Mani (3):
thunderbolt: Make tb_switch_find_cap() available to other files
thunderbolt: Add support for Time Management Unit
thunderbolt: Add support for USB tunnels

 .../ABI/testing/sysfs-bus-thunderbolt         |  17 +
 Documentation/admin-guide/thunderbolt.rst     |  27 +-
 drivers/thunderbolt/Kconfig                   |   9 +-
 drivers/thunderbolt/Makefile                  |   2 +-
 drivers/thunderbolt/cap.c                     |  11 +-
 drivers/thunderbolt/ctl.c                     |   8 +-
 drivers/thunderbolt/eeprom.c                  | 146 +--
 drivers/thunderbolt/icm.c                     |  36 +-
 drivers/thunderbolt/lc.c                      | 193 +++-
 drivers/thunderbolt/nhi.c                     |   3 +
 drivers/thunderbolt/nhi.h                     |   2 +
 drivers/thunderbolt/path.c                    |  52 +-
 drivers/thunderbolt/switch.c                  | 870 +++++++++++++++---
 drivers/thunderbolt/tb.c                      | 529 +++++++++--
 drivers/thunderbolt/tb.h                      | 198 +++-
 drivers/thunderbolt/tb_msgs.h                 |   2 +
 drivers/thunderbolt/tb_regs.h                 | 160 +++-
 drivers/thunderbolt/tmu.c                     | 380 ++++++++
 drivers/thunderbolt/tunnel.c                  | 517 ++++++++++-
 drivers/thunderbolt/tunnel.h                  |  19 +-
 drivers/thunderbolt/usb4.c                    | 761 +++++++++++++++
 drivers/thunderbolt/xdomain.c                 |   8 +-
 22 files changed, 3578 insertions(+), 372 deletions(-)
 create mode 100644 drivers/thunderbolt/tmu.c
 create mode 100644 drivers/thunderbolt/usb4.c
Signature · 1 line
2.23.0