Skip to content

Coverity fixes and other cleanups

Kevin Traynor dpdk-dev 2 versions – Applied

Status from this message: Applied, thanks.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest8 patches 6 repliesApplied
  2. v19 patches 25 repliesSuperseded

Changes in v2 from the cover letter

- 1/8: removed added NULL check for devargs_all
- 2/8: fixed headline to common/cpt
- v1 3/9 'net/bnxt: remove logically dead code'
removed as duplicate patch already applied

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/8net/pcap: fix argument checksdrivers/net/pcap/rte_eth_pcap.c+0 -60 replies
2/8common/cpt: fix possible NULL deferencedrivers/common/cpt/cpt_ucode.h+2 -10 replies
3/8net/ipn3ke: fix incorrect commit check logicdrivers/net/ipn3ke/ipn3ke_tm.c+0 -61 reply
4/8net/ipn3ke: remove useless if statementdrivers/net/ipn3ke/ipn3ke_ethdev.c+1 -21 reply
5/8net/ipn3ke: remove commented out codedrivers/net/ipn3ke/ipn3ke_ethdev.h drivers/net/ipn3ke/ipn3ke_tm.c+0 -81 reply
6/8compress/octeontx: remove commented out codedrivers/compress/octeontx/include/zip_regs.h+0 -80 replies
7/8event/opdl: remove commented out codedrivers/event/opdl/opdl_test.c+0 -30 replies
8/8net/bnxt: remove commented out codedrivers/net/bnxt/bnxt_ethdev.c+0 -30 replies

Reviews trailers per patch

All 8 patches have a Reviewed-by or Acked-by.

PatchCian FerriterDavid MarchandLiang MaAjit KhapardeRosen Xu
1/8A-b
2/8R-b
3/8R-b
4/8R-b R-b
5/8R-b R-b
6/8R-b
7/8A-b
8/8A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.

Read the v2 thread

Cover letter [dpdk-dev] [v2 PATCH 0/8] Coverity fixes and other cleanups

Patches 1-4 are Coverity fixes.
Patches 5-8 are removing commented out code.

v2:
- 1/8: removed added NULL check for devargs_all
- 2/8: fixed headline to common/cpt
- v1 3/9 'net/bnxt: remove logically dead code'
removed as duplicate patch already applied

Kevin Traynor (8):
net/pcap: fix argument checks
common/cpt: fix possible NULL deference
net/ipn3ke: fix incorrect commit check logic
net/ipn3ke: remove useless if statement
net/ipn3ke: remove commented out code
compress/octeontx: remove commented out code
event/opdl: remove commented out code
net/bnxt: remove commented out code

 drivers/common/cpt/cpt_ucode.h               | 3 ++-
 drivers/compress/octeontx/include/zip_regs.h | 8 --------
 drivers/event/opdl/opdl_test.c               | 3 ---
 drivers/net/bnxt/bnxt_ethdev.c               | 3 ---
 drivers/net/ipn3ke/ipn3ke_ethdev.c           | 3 +--
 drivers/net/ipn3ke/ipn3ke_ethdev.h           | 7 -------
 drivers/net/ipn3ke/ipn3ke_tm.c               | 7 -------
 drivers/net/pcap/rte_eth_pcap.c              | 6 ------
 8 files changed, 3 insertions(+), 37 deletions(-)
Signature · 1 line
2.21.0